Skip to content

SCSS partials not properly updating the files that import them #26390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brianmtreese opened this issue Nov 16, 2023 · 6 comments
Closed

SCSS partials not properly updating the files that import them #26390

brianmtreese opened this issue Nov 16, 2023 · 6 comments
Labels
needs: more info Reporter must clarify the issue

Comments

@brianmtreese
Copy link

Which @angular/* package(s) are the source of the bug?

Don't known / other

Is this a regression?

Yes

Description

After updating to angular 17, when making changes to SCSS partials used in components, the changes do not take effect unless you go into the file that's importing them and trigger a save.

You can easily see this by going to the link for the reproduction, changing the color to something else, like "purple", and then saving. The color will not be changed until going into the component stylesheet (test-component.component.scss) where the variable is imported and used, and triggering a save there instead.

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/stackblitz-starters-y1ihag?file=src%2Ftest-component%2F_test-import.scss

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Angular: 17.0.3
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Anything else?

No response

@JoostK JoostK transferred this issue from angular/angular Nov 17, 2023
@alan-agius4
Copy link
Collaborator

I am not able to replicate this outside of stackblitz. If you are replicating it locally, can you please provide the output of ng version.

@alan-agius4 alan-agius4 added the needs: more info Reporter must clarify the issue label Nov 17, 2023
@brianmtreese
Copy link
Author

brianmtreese commented Nov 17, 2023

@alan-agius4 ok, no problem. I also created a brand new app and replicated the issue outside of stackblitz (https://github.com/brianmtreese/scss-partials-issue).

Angular CLI: 17.0.1
Node: 18.18.0
Package Manager: npm 10.2.1
OS: win32 x64

Angular: 17.0.3
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1700.1
@angular-devkit/build-angular 17.0.1
@angular-devkit/core 17.0.1
@angular-devkit/schematics 17.0.1
@angular/cli 17.0.1
@schematics/angular 17.0.1
rxjs 7.8.1
typescript 5.2.2
zone.js 0.14.2

@clydin
Copy link
Member

clydin commented Nov 21, 2023

Is this still an issue for you with @angular-devkit/[email protected]?

@brianmtreese
Copy link
Author

Nope, it appears to be fixed now. Thanks!

@clydin
Copy link
Member

clydin commented Nov 21, 2023

Good to hear and thank you for confirming.

@clydin clydin closed this as completed Nov 21, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: more info Reporter must clarify the issue
Projects
None yet
Development

No branches or pull requests

3 participants