Skip to content

Found mostly working esbuild Angular compiler - fix pending issues and use it for Angular CLI build? #23153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
vzakharov-rxnt opened this issue May 17, 2022 · 5 comments

Comments

@vzakharov-rxnt
Copy link

vzakharov-rxnt commented May 17, 2022

🚀 Feature request

Command (mark with an x)

  • build
  • serve

Description

I found a mostly working esbuild compiler for Angular. I know Angular team is investigating this, so could be of some help.

Describe the solution you'd like

Please expedite build speed improvements, current Angular 13.x builds are too slow, even my most simple app with 5k of own LOC and 1.8MB JS bundle size takes 2min to build on a CI/CD agent. I checked other questions here, I would be fine to not have type checking, I can add a parallel type check with npm-run-all, it would still be faster.

For example, one enterprise application that I have here, with 15MB bundle size (combined main and lazy chunks), takes 1min to build with Angular 13 CLI on my Ryzen 9 laptop. It's a mix of Angular 13 and Angular 1.x code. Another enterprise application with the same bundle size takes 30 seconds to build with webpack/esbuild-loader and type checks running in parallel. It only has Angular 1.x code, no Angular 13.

Assuming the above data and linear correlation between output bundle size and build time (15MB / 1.8MB * 2min), I estimate 16min on a CI/CD agent for our larger app.

Describe alternatives you've considered

N/A

@alan-agius4
Copy link
Collaborator

One of the features of version 14 which is currently in RC stage is an experimental EsBuild browser builder. See #22995 for more information.

Closing since this feature is already present as an opt-in experiment.

@vzakharov-rxnt
Copy link
Author

vzakharov-rxnt commented May 17, 2022

@alan-agius4 Thanks. Do you plan to support SCSS? Other unsupported features are probably fine, but I can't imagine anyone using raw CSS in 2022.

@alan-agius4
Copy link
Collaborator

Support for SCSS will be added down the line based on the feedback we receive.

But I can't imagine anyone using raw CSS in 2022.

Surprising a large percentage of users still use plain CSS.

@vzakharov-rxnt
Copy link
Author

@alan-agius4 Does it mean SCSS is not planned for v14 ?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants