Skip to content

ng serve does not generate service worker files #18876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 15 tasks
koenig-dominik opened this issue Sep 24, 2020 · 2 comments
Closed
2 of 15 tasks

ng serve does not generate service worker files #18876

koenig-dominik opened this issue Sep 24, 2020 · 2 comments

Comments

@koenig-dominik
Copy link

koenig-dominik commented Sep 24, 2020

🚀 Feature request

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

A clear and concise description of the problem or missing capability...

The command ng serve currently does not generate service worker files.
It may be because in the past it was not possible to register service workers in non SSL sites.
There is now a exception to that, all http://localhost or http://127.x.y.z addresses do work (at least in Chrome)
This was already shortly discussed in #16883 (comment) but only the generation for ng build --watch was implemented.
ng serve & serve-ssr do not generate these files.

Describe the solution you'd like

If you have a solution in mind, please describe it.

Generate the needed service worker files in @angular-devkit/build-angular:dev-server & @nguniversal/builders:ssr-dev-server

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?

Build the universal server & run that without serve-ssr, which is really cumbersome in development

@ngbot ngbot bot added this to the needsTriage milestone Sep 24, 2020
@alan-agius4 alan-agius4 added devkit/build-angular:dev-server feature Issue that requests a new feature labels Sep 24, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Sep 24, 2020
@alan-agius4
Copy link
Collaborator

Duplicate of #9869

@alan-agius4 alan-agius4 marked this as a duplicate of #9869 Dec 1, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants