Skip to content

npm run build fails #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catull opened this issue Aug 29, 2016 · 4 comments
Closed

npm run build fails #1876

catull opened this issue Aug 29, 2016 · 4 comments

Comments

@catull
Copy link
Contributor

catull commented Aug 29, 2016

  1. OS?
    Not an OS-specific problem
  2. Versions.
    npm --version is 3.10.6
    node --version v6.4.0
  3. Repro steps.
    npm run build
  4. The log given by the failure.
> [email protected] build /Users/carlo/workspace/javascript/ng/angular-cli.git
> npm-run-all -c build:main build:packages


> [email protected] build:main /Users/carlo/workspace/javascript/ng/angular-cli.git
> tsc -p addon/ng2

addon/ng2/commands/init.ts(58,9): error TS7005: Variable 'gitInit' implicitly has an 'any' type.
addon/ng2/commands/init.ts(66,9): error TS7005: Variable 'linkCli' implicitly has an 'any' type.
addon/ng2/commands/init.ts(75,9): error TS7005: Variable 'npmInstall' implicitly has an 'any' type.
addon/ng2/commands/init.ts(84,9): error TS7005: Variable 'bowerInstall' implicitly has an 'any' type.
  ...

I am surprised this is not caught automatically.
tsconfig.json, line 10, states

....
    "noImplicitAny": true,
@catull
Copy link
Contributor Author

catull commented Aug 29, 2016

In order to get here, you have to first implement the suggested "fix" mentioned in issue #1853.

@catull
Copy link
Contributor Author

catull commented Aug 30, 2016

There is an alternative.

Since tsc is instructed not to allow implicit any, make the explicit.
This works.

@filipesilva
Copy link
Contributor

I think this has since been addressed. If that's not the case, please tell me and I will reopen.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants