Skip to content

Copy Images / Specific Directories to Dist from node_modules #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sqwk opened this issue Aug 22, 2016 · 5 comments
Closed

Copy Images / Specific Directories to Dist from node_modules #1801

sqwk opened this issue Aug 22, 2016 · 5 comments

Comments

@sqwk
Copy link

sqwk commented Aug 22, 2016

In the old system.js cli version, there was an option to copy files from node_modules to the dist/vendor directory using the vendorNpmFiles array.

module.exports = function(defaults) {
    return new Angular2App(defaults, {
        vendorNpmFiles: [
        '...',
        'font-awesome/fonts/**/*',
        '...'
        ]
    });
};

Where has this functionality gone in the new webpack based cli?

EDIT: Has this been solved by #1633?

@filipesilva
Copy link
Contributor

For fonts and other CSS referenced thing yes, it should be solved in #1633.

@Dinistro
Copy link

@filipesilva I'm sorry to disturb you, but I don't see how I can use something like vendorNpmFiles. I'm trying to load some images from the node_modules. I added them in the assets array, but it looks like the relative path to node_modules breaks the copy process.

"assets": [
        "assets",
        "../node_modules/oblique-ui/dist/images/favicon.ico",
        "../node_modules/oblique-ui/dist/images/logo.svg"
      ],

Can you elaborate how this was fixed in #1633?

@filipesilva
Copy link
Contributor

@Dinistro the assets array does not yet support copying over files from other directories, that is being requested in #3555.

If you need that functionality right now, I suggest you copy over the icon and logo onto assets/ for now.

@Dinistro
Copy link

@filipesilva Thank you for the quick reply. I will take a look at the mentioned Issue.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants