Following the upgrade guide from 7 to 8 fails on Windows

[un33k]

🐞 Bug report

Command

• [ x ] update

Is this a regression?

No

Description

Was unable to find an existing issue for the bug I am reporting. is:issue, is:open, is:close.
Following the online update guideline, and yet unable to move forward with a simple ng update.

🔬 Minimal Reproduction

Private "corporate code" unable to reproduce on a minimal version. However, I am attaching an image to show the anomaly.

🔥 Exception or Error

$ ng update @angular/[email protected]
The installed Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.
Installing packages for tooling via yarn.
Installed packages for tooling via yarn.
Using package manager: 'yarn'
Collecting installed dependencies...
Found 0 dependencies.
Package '@angular/core' is not a dependency.

🌍 Your Environment

Angular CLI: 8.3.26
Node: 10.16.3
OS: win32 x64
Angular: 7.2.15
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.13.9
@angular-devkit/build-angular     0.13.9
@angular-devkit/build-optimizer   0.13.9
@angular-devkit/build-webpack     0.13.9
@angular-devkit/core              8.3.26
@angular-devkit/schematics        8.3.26
@angular/cdk                      7.3.2
@angular/cli                      8.3.26
@angular/flex-layout              7.0.0-beta.24
@angular/http                     7.2.16
@angular/material                 7.3.2
@ngtools/webpack                  7.3.9
@schematics/angular               8.3.26
@schematics/update                0.803.26
rxjs                              6.5.4
typescript                        3.2.4
webpack                           4.29.0

Anything else relevant?
Windows 10, The plan is to update from 7 to 9, via 8.

[alan-agius4]

Hi @un33k, thanks for reporting this issue.

However, we will need a reproduction to look into this, the screenshots alone don’t provide enough information to reproduce the problem.

Thanks.

[un33k]

Ok, I think I have figured out the steps ... and it may be repo independent.

1. Create a repo with ng/cli 7.x.x (& npm install)
2. Run: node --max_old_space_size=2000 /usr/local/bin/ng update @angular/cli@8 @angular/core@8 --force (We want to simulated an out of heap memory)
3. Verify that above node command runs out of heap memory
4. Run: node --max_old_space_size=12000 /usr/local/bin/ng update @angular/cli@8 @angular/core@8 --force (Give it plenty of memory)
5. Verify that the command now fails right away with Package '@angular/core' is not a dependency.
6. Remove node_modules && npm install
7. Run: node --max_old_space_size=12000 /usr/local/bin/ng update @angular/cli@8 @angular/core@8 --force
8. Verify it no longer fails with the Package '@angular/core' is not a dependency. error.

So, the proper fix would be to not fail with Package '@angular/core' is not a dependency. if we run the update command again right after a heap memory error.

[clydin]

Since the first update command failed, the node_modules directory will most likely be corrupt. The update process checks the node_modules directory for dependencies. If it cannot find it there or it is corrupt then it will present the error message as shown above.
Future improvements to the update command will also support updating without a node modules directory present. This is being tracked here: #17599 & #16020

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}