-
Notifications
You must be signed in to change notification settings - Fork 12k
Clarify the purpose of polyfills.ts #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suspect the comment is just some leftover bit; but it would be nice to get a sense of why the polyfills file is generated in to the project, while many other pieces of machinery are internal to the CLI. |
@kylecordes it's reasonable to want to change these polyfills according to your intended browser environment. You might also use more polyfills for certain environments. #1633 expands on the |
@filipesilva I suggest documenting that in the README, and it would be a much more useful comment to include at the top of the polyfill file than the current "// Prefer CoreJS over the polyfills above". |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
https://github.com/angular/angular-cli/blob/master/addon/ng2/blueprints/ng2/files/__path__/polyfills.ts#L1
The comment right now has no meaning. Explain what this file does and in what case people would want to read/change this file.
The text was updated successfully, but these errors were encountered: