Skip to content

Clarify the purpose of polyfills.ts #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hansl opened this issue Aug 9, 2016 · 4 comments · Fixed by #1633
Closed

Clarify the purpose of polyfills.ts #1618

hansl opened this issue Aug 9, 2016 · 4 comments · Fixed by #1633
Assignees

Comments

@hansl
Copy link
Contributor

hansl commented Aug 9, 2016

https://github.com/angular/angular-cli/blob/master/addon/ng2/blueprints/ng2/files/__path__/polyfills.ts#L1

The comment right now has no meaning. Explain what this file does and in what case people would want to read/change this file.

@kylecordes
Copy link

I suspect the comment is just some leftover bit; but it would be nice to get a sense of why the polyfills file is generated in to the project, while many other pieces of machinery are internal to the CLI.

@filipesilva
Copy link
Contributor

@kylecordes it's reasonable to want to change these polyfills according to your intended browser environment. You might also use more polyfills for certain environments.

#1633 expands on the polyfills.ts file to make it more explicit. You could even remove it and delete the config entry.

@kylecordes
Copy link

@filipesilva I suggest documenting that in the README, and it would be a much more useful comment to include at the top of the polyfill file than the current "// Prefer CoreJS over the polyfills above".

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants