Skip to content

fix(@angular-devkit/build-angular): mangle scripts when differential loading is enabled #15507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 2, 2019

Previously scripts.js were not being mangled

Closes #15489

@alan-agius4 alan-agius4 requested a review from clydin September 2, 2019 16:31
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 2, 2019
@alan-agius4 alan-agius4 closed this Sep 2, 2019
@alan-agius4 alan-agius4 reopened this Sep 2, 2019
…loading is enabled

Previously scripts.js were not being mangled

Closes #15489
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): scripts not minified for prod build fix(@angular-devkit/build-angular): mangle scripts when differential loading is enabled Sep 2, 2019
@alan-agius4 alan-agius4 requested review from clydin and removed request for clydin September 9, 2019 18:46
clydin added a commit to clydin/angular-cli that referenced this pull request Sep 10, 2019
…h bundle downleveling

This also allows terser to perform ECMA 6 level compress optimizations on the actual application bundles (non-script bundles) which can provide for further size improvements.

Fixes angular#15507
@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Sep 10, 2019

Superseded by #15566

@alan-agius4 alan-agius4 deleted the optimize-scripts branch September 10, 2019 16:57
kyliau pushed a commit that referenced this pull request Sep 10, 2019
…h bundle downleveling

This also allows terser to perform ECMA 6 level compress optimizations on the actual application bundles (non-script bundles) which can provide for further size improvements.

Fixes #15507
clydin added a commit to clydin/angular-cli that referenced this pull request Sep 10, 2019
…h bundle downleveling

This also allows terser to perform ECMA 6 level compress optimizations on the actual application bundles (non-script bundles) which can provide for further size improvements.

Fixes angular#15507
kyliau pushed a commit that referenced this pull request Sep 10, 2019
…h bundle downleveling

This also allows terser to perform ECMA 6 level compress optimizations on the actual application bundles (non-script bundles) which can provide for further size improvements.

Fixes #15507
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular CLI 8.3.0: scripts.js not minified for prod build
2 participants