-
Notifications
You must be signed in to change notification settings - Fork 12k
Generate module command adds route path to wrong line #15117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you please provide the output of |
Sure, Angular CLI: 8.1.2 Package Version@angular-devkit/architect 0.801.2 |
… for child nodes of kind Curtrently, when a node of kind is found, we recursivly continue to look up it's child nodes until the end of the AST. This ends up returing other nodes which we were not looking for as typically we are looking for the first level of children of the specified kind. By default now, we stop recursivly looking for child nodes of kind when we encounter one. Closes #15117
… for child nodes of kind Curtrently, when a node of kind is found, we recursivly continue to look up it's child nodes until the end of the AST. This ends up returing other nodes which we were not looking for as typically we are looking for the first level of children of the specified kind. By default now, we stop recursivly looking for child nodes of kind when we encounter one. Closes #15117
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Bug report
Command (mark with an
x
)Description
ng generate module ranking --route ranking --module app.module
command is working very well. But if there is a data property to routes inapp-routing.module
. The command add route path to wrong line.🔬 Minimal Reproduction
ng new example-app --routing
ng generate module ranking --route ranking --module app.module
Add data property to ranking route, then my app-routing.module.ts like below
After, run the following command
ng generate module home --route home --module app.module
It adds my home route path to the wrong line like below:
The text was updated successfully, but these errors were encountered: