-
Notifications
You must be signed in to change notification settings - Fork 12k
Source maps does not work #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@TheLarkInn should your sourcemap solution have fixed this scenario? |
This is a chrome issue I believe @mmrath can you do me a favor and try this in Chrome Canary just to make sure it's the issue I believe it is. |
@TheLarkInn I tried it in Chrome Canary, the behaviour is same. It still does not work. Update: Chrome Version 54.0.2811.2 canary (64-bit) |
This could be related to webpack/webpack#2145 |
Yup that was the issue I was looking for. I will be speaking with a few folks from Chrome next week (in the context of that issue and other stuff). I'll make sure to keep track of this and update accordingly. |
I can confirm this, having the same issue. It only debugs if i add a debugger; in my code ;) |
@TheLarkInn Does not look like this issue is resolved. I have seen the commit #1659 . I took the latest master and created a new project added material2. Now ng serve is failing. If I change to Sample repo to reproduce is at https://github.com/mmrath/test-cli-source-map.git
TypeError: Cannot read property 'substr' of undefined |
Source maps are working after your commit @TheLarkInn at least at my place. |
@masaanli any chance you can try the repo I mentioned in the previous comments. It would be good to if it is just me. I tried in on both my windows and Mac |
Reopening to investigate @mmrath's report. |
@mmrath I have got the same Also, not all of material2 modules trigger this error. If you import just some of them project will compile. Also, source maps are wrong with ng2-bootstrap v1.0.24 But @ng-bootstrap/ng-bootstrap 1.0.0-alpha.2 works well. |
May be this is an issue with precompiled source maps in some material2 and ng2-bootstrap modules. |
@mmrath it took me a while to get back to this, apologies. I tried with the latest I think this was due to buggy source maps on these libs before. For instance, a while ago all the sourcemaps the CLI generated were themselves broken. In this case, the best we can do is to ignore them since it broken sourcemaps there is no way to accurately debug the source. |
I don't know whether it has the same cause but source maps are not working in my project either. I'm using [email protected] and @angular/[email protected] |
@dancancro there was a regression in beta.18 with sourcemaps, upgrading to beta.19-3 should fix it. |
Thank you. It looks like that fixed it. |
This error is occurring in "angular-cli": "1.0.0-beta.21" |
@doliver3 can you tell me how you repro'd it? |
I also have this problem running angular-cli 1.0.0-beta.24. It only occurs when running |
For docker users. Are your node_modules being shared from the host machine? there may be an issue with how docker follows the sym-links in your mounted directories. Look into installing node_modules with --no-bin-links |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OSX El Captain, Windows 7
ng --version
. If there's nothing outputted, please runin a Terminal:
node --version
and paste the result here:latest master
do on your code? etc.
https://github.com/mmrath/cli-proxy-test.git
Keep break points in app.component.ts from chrome. Chrome does not stop on the right place.
more information.
The text was updated successfully, but these errors were encountered: