Skip to content

NamedExports from barrel files are not dynamically imported for lazy loading properly. #14707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FrozenPandaz opened this issue Jun 7, 2019 · 1 comment · Fixed by #15189
Closed

Comments

@FrozenPandaz
Copy link
Contributor

🐞 Bug report

Command (mark with an x)

- [x] build
- [x] serve

Is this a regression?

Yes, the previous version in which this bug was not present was: ....

Yes, sort of. This worked in 7 with the loadChildren strings but does not work in 8.

Description

A clear and concise description of the problem...

This was originally reported in nrwl/nx#1471.

This is an extension of #14399. The fix for that issue solves it for unnamed ExportDeclarations but not for NamedExports.

// export * from './lib/my.module'; // This works
export { MyModule } from './lib/my.module'; // This does not work

🔬 Minimal Reproduction

https://github.com/FrozenPandaz/demos/blob/lazybug/libs/lib1/src/index.ts

🔥 Exception or Error

ERROR in ./src/app/app.module.ts
Module not found: Error: Can't resolve './../../../../libs/lib1/src/index.ngfactory' in '/Users/jason/projects/temp/temp/nx8-test/apps/app1/src/app'

🌍 Your Environment

8.0.1

Anything else relevant?
May affect Nx Users.

cc @filipesilva who resolved #14399

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
ikjelle pushed a commit to ikjelle/angular-cli that referenced this issue Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants