Skip to content

Generated directive does not follow the styleguide #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gelio opened this issue Jul 23, 2016 · 4 comments
Closed

Generated directive does not follow the styleguide #1435

Gelio opened this issue Jul 23, 2016 · 4 comments

Comments

@Gelio
Copy link
Contributor

Gelio commented Jul 23, 2016

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    Windows 10
  2. Versions.
    angular-cli: 1.0.0-beta.10
    node: 6.2.2
    os: win32 x64
  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
ng generate directive AnimateOnScroll

The generated class's name is simply AnimateOnScroll, but according to the styleguide it should be AnimateOnScrollDirective

  1. The log given by the failure. Normally this include a stack trace and some
    more information.
    Not related.
  2. Mention any other details that might be useful.
@paganotoni
Copy link

I think this is a duplicate of #1217, right ?

@filipesilva
Copy link
Contributor

Correct, it is a duplicate. Closing, but the other issue will receive attention.

@paganotoni
Copy link

@filipesilva awesome, thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants