Skip to content

Generating directive inserts wrong file name in the barrel #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gelio opened this issue Jul 23, 2016 · 6 comments
Closed

Generating directive inserts wrong file name in the barrel #1434

Gelio opened this issue Jul 23, 2016 · 6 comments

Comments

@Gelio
Copy link
Contributor

Gelio commented Jul 23, 2016

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    Windows 10
  2. Versions
    angular-cli: 1.0.0-beta.10
    node: 6.2.2
    os: win32 x64
  3. Repro steps
ng generate directive AnimateOnScroll

This creates the directive with a filename animate-on-scroll.directive.ts along with its spec file.

  create src\app\shared\animate-on-scroll.directive.spec.ts
  create src\app\shared\animate-on-scroll.directive.ts

index.ts now contains the following line:

export * from './AnimateOnScroll.directive';

Which results in an error, because no such file exists. It should instead be:

export * from './animate-on-scroll.directive';
  1. The log given by the failure. Normally this include a stack trace and some
    more information.
    Not related.
  2. Mention any other details that might be useful.
    It seems like the name of the file created is changed from PascalCase to kebab-case, but the entry in the barrel is not. I haven't dug inside angular-cli's code, so I can't help to identify in which file the issue is present, otherwise I would have made a pull request already.
@aciccarello
Copy link
Contributor

Possibly a duplicate of #1305?

@filipesilva
Copy link
Contributor

Dupe of #1418, made obsolete by #1455.

@filipesilva
Copy link
Contributor

Oh my bad, it's not related to #1418 at all! Reopening.

@filipesilva filipesilva reopened this Jul 27, 2016
@filipesilva
Copy link
Contributor

Yes dupe of #1305, but this issue contains more details useful for the fix so I will keep this one open.

@filipesilva
Copy link
Contributor

We don't automatically add stuff to barrels anymore, so this issue is now obsolete.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants