Skip to content

es5BrowserSupport add additional polyfill #13622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fetters5 opened this issue Feb 8, 2019 · 2 comments
Closed

es5BrowserSupport add additional polyfill #13622

fetters5 opened this issue Feb 8, 2019 · 2 comments

Comments

@fetters5
Copy link

fetters5 commented Feb 8, 2019

🚀 Feature request

Command (mark with an x)

- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

When setting "es5BrowserSupport": true in angular.json I get errors in IE 11 because it does not recognize .includes()
TypeError: Object doesn't support property or method 'includes'

This issue below gave the original workaround, perhaps now that it is in a conditional polyfill we can add it by default.
#4128

Describe the solution you'd like

Add the following polyfill to the Conditional ES5 Browser Polyfill so that .includes() works with IE 11
import 'core-js/es7/array';

Describe alternatives you've considered

I can keep import 'core-js/es7/array'; in the main polyfill file, but it is not needed by other browsers

@alan-agius4
Copy link
Collaborator

The includes, is not part of the ES6 but ES7 specs.

Hence some browsers that support ES6 might still need to use this polyfill to function properly.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants