Skip to content

value.split is not a function #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scrivy opened this issue Jul 5, 2016 · 4 comments
Closed

value.split is not a function #1286

scrivy opened this issue Jul 5, 2016 · 4 comments
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion type: bug/fix

Comments

@scrivy
Copy link

scrivy commented Jul 5, 2016

  1. Mac OSX El Capitan 10.11.5
  2. angular-cli: 1.0.0-beta.9, node: 4.4.6, os: darwin x64
  3. Repro steps.

Run ng init to upgrade from angular-cli 1.0.0-beta.7 to beta.9, when asked to Overwrite src/favicon.ico? try to diff

? Overwrite src/favicon.ico? Diff
value.split is not a function
TypeError: value.split is not a function
at Object.lineDiff.tokenize (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/diff/line.js:22:32)
at Object.diff (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/diff/base.js:36:39)
at diffLines (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/diff/line.js:47:19)
at structuredPatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/patch/create.js:18:83)
at createTwoFilesPatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/patch/create.js:131:14)
at Object.createPatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/patch/create.js:151:10)
at /srv/fuma/frontend/node_modules/angular-cli/node_modules/angular-cli/lib/models/file-info.js:65:23
at lib$rsvp$$internal$$tryCatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1036:16)
at lib$rsvp$$internal$$invokeCallback (/srv/fuma/frontend/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1048:17)
at lib$rsvp$$internal$$publish (/srv/fuma/frontend/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1019:11)

@filipesilva
Copy link
Contributor

That's a bug that I don't think we can fix right now. The ng init command on the version of ember-cli we use fails when diffing images.

@filipesilva filipesilva added the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label Jul 28, 2016
@dzonatan
Copy link
Contributor

I think this is fixed by #2617 and can be closed.

@filipesilva
Copy link
Contributor

@dzonatan is most correct, thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion type: bug/fix
Projects
None yet
Development

No branches or pull requests

3 participants