Skip to content

ng add github repository #12263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
boulix3 opened this issue Sep 13, 2018 · 5 comments
Closed

ng add github repository #12263

boulix3 opened this issue Sep 13, 2018 · 5 comments
Labels
area: @angular/cli feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature freq1: low Only reported by a handful of users who observe it rarely workaround2: non-obvious
Milestone

Comments

@boulix3
Copy link

boulix3 commented Sep 13, 2018

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ X] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [X ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node 8.1.1
npm 5.6.0
Windows 10

Repro steps

ng add https://github.com/boulix3/store-builds doesn't work
npm i https://github.com/boulix3/store-builds installs the package from github

The log given by the failure

  • Using owner/repo-name
λ ng add boulix3/store-builds
Installing packages for tooling via npm.
npm ERR! code E404
npm ERR! 404 Not Found: boulix3@latest
  • Using another syntax compatible with npm install
λ ng add git+https://github.com/boulix3/store-builds
Installing packages for tooling via npm.
npm ERR! Error while executing:
npm ERR! C:\softs\cmder\vendor\git-for-windows\cmd\git.EXE ls-remote -h -t https:
npm ERR!
npm ERR! ssh: Could not resolve hostname https: Name or service not known
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR!
npm ERR! exited with error code: 128

I've also tried the various syntaxes to add a package listed in this documentation page https://docs.npmjs.com/cli/install such as git:// etc...

Desired functionality

It would be nice to be able to install a package from github and execute the ng-add schematic.

Mention any other details that might be useful

I seems to me that when the ng add command passes the package name to npm, it splits on '/' and only takes the first item (boulix3 the first example, and https: in the second) and passes it to npm.

@boulix3
Copy link
Author

boulix3 commented Sep 13, 2018

For information, here is the workaround I use

npm i owner/repo-name
ng g package-name:ng-add

@ngbot ngbot bot added this to the needsTriage milestone Sep 14, 2018
@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient workaround2: non-obvious labels Sep 14, 2018
@alan-agius4 alan-agius4 added the feature Issue that requests a new feature label Nov 12, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 12, 2018
@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Feb 1, 2022
@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 1, 2022

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@ngbot ngbot bot modified the milestones: Backlog, needsTriage Feb 1, 2022
@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 21, 2022

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors and removed feature: votes required Feature request which is currently still in the voting phase labels Feb 21, 2022
@alan-agius4
Copy link
Collaborator

Thanks for reporting this issue. Luckily, it has already been fixed in one of the recent releases. Please update to the most recent version to resolve the problem.

If the problem persists in your application after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use ng new repro-app to create a new project where you reproduce the problem.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature freq1: low Only reported by a handful of users who observe it rarely workaround2: non-obvious
Projects
None yet
Development

No branches or pull requests

2 participants