Skip to content

Regression: ng-add @nativescript/schematics doesn't work with @angular/[email protected] or -beta.2 #11174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebawita opened this issue Jun 8, 2018 · 5 comments · Fixed by #11524
Labels
area: @angular/cli area: @angular-devkit/schematics freq3: high P0 Issue that causes an outage, breakage, or major function to be unusable, with no known workarounds severity5: regression

Comments

@sebawita
Copy link

sebawita commented Jun 8, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Area

- [x] devkit
- [ ] schematics

Versions

@angular/[email protected] - not working
@angular/[email protected] - works OK

Repro steps

run the following commands

with @angular/[email protected]

ng new proj608
cd proj608
ng add @nativescript/schematics

with @angular/[email protected]

ng new proj610
cd proj610
ng add @nativescript/schematics

The proj608, will contain the App_Resources folder with a bunch of files
The proj610, will be missing the App_Resources folder.

The code that calls App_Resources is located here:
https://github.com/NativeScript/nativescript-schematics/blob/master/src/add-ns/index.ts#L130-L135

Which then calls this simple schematic:
https://github.com/NativeScript/nativescript-schematics/blob/master/src/app-resources/index.ts

I have a feeling that the last mergeWith that executes in the schematics chain erases all the previous ones:
https://github.com/NativeScript/nativescript-schematics/blob/master/src/add-ns/index.ts#L199

The log given by the failure

Desired functionality

Mention any other details that might be useful

@hansl
Copy link
Contributor

hansl commented Jun 8, 2018

This seems to work with CLI 6.1.0-beta.2, so I think it was a bug in Schematics in the beta 0 (we fixed a few of these).

Closing this as cannot repro.

@hansl hansl closed this as completed Jun 8, 2018
@hansl
Copy link
Contributor

hansl commented Jun 8, 2018

Reference:
image

@hansl
Copy link
Contributor

hansl commented Jun 8, 2018

Apparently my setup was wrong. Reopening.

@hansl hansl reopened this Jun 8, 2018
@filipesilva filipesilva added area: @angular/cli P0 Issue that causes an outage, breakage, or major function to be unusable, with no known workarounds freq3: high severity5: regression area: @angular-devkit/schematics labels Jun 10, 2018
@sebawita
Copy link
Author

I've created a sample project that recreates the issue:
https://github.com/sebawita/sample

See readme for repro steps

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli area: @angular-devkit/schematics freq3: high P0 Issue that causes an outage, breakage, or major function to be unusable, with no known workarounds severity5: regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants