Skip to content

Please consider add "Typings" npm package to "Prerequisites" #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CarreraPHP opened this issue Jun 14, 2016 · 3 comments
Closed

Please consider add "Typings" npm package to "Prerequisites" #1087

CarreraPHP opened this issue Jun 14, 2016 · 3 comments

Comments

@CarreraPHP
Copy link
Contributor

OS - Mac OSX (El Capitan)

Version -
angular-cli: 0.0.39
node: 5.0.0
os: darwin x64

Repro steps -
Install angular-cli without Typings npm package.

The log given by the failure -
"Typings" folder missing
"browser.d.ts" file missing.

Please consider add "Typings" npm package to "Prerequisites"

@kylecordes
Copy link

I have a request which might the sense be the opposite of this one: Don't require or ask users to "npm install -g typings". That so easily leads to incorrect results because of version skew. Rather, the user should only need to do that if they explicitly want the convenience of running the tool themselves at the command line without "node_modules/.bin/typings". And even then it only works correctly if the tool (which I believe this one does) has code in it to ignore the global installation (making all those extra bits wasted anyway) and run the project local one.

When something like CLI needs to call something like typings, it should only always ever used the locally installed one, never use a globally installed one even if it is present. Therefore, if it has a dependency, it does not need to describe it as a prerequisite, rather it needs to simply declare it as a devDependency in the normal way.... Which it already does.

So if there is an actual bug here, then it is some case by which CLI, when it calls typings, erroneously relies on a global install.

@filipesilva
Copy link
Contributor

That was old (and erroneous) behavior that has since been fixed, newer versions of the CLI have a local typings install.

There is a bug in beta.6 that requires a global typings install, but that is also unintended and were are looking to fix it: #1092

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants