Missing providedIn in ng g guard

[cyrilletuzi]

Versions

v6.0.0

Repro steps

• npm install @angular/cli -g
• ng new helloworld --routing
• cd helloworld
• ng g guard hello

Observed behavior

@Injectable()
export class HelloGuard implements CanActivate { ... }

Desired behavior

@Injectable({
  providedIn: 'root'
})
export class HelloGuard implements CanActivate { ... }

Mention any other details that might be useful (optional)

PR : angular/devkit#795

[cyrilletuzi]

@Brocco I don't understand why you closed the PR: as a service, if the guard is not provided either via providedIn: 'root' or in a module (which have now been explicitly discouraged in v6, see #10170), where is it provided? I just tried to just pass a guard to canActivate without provider and as expected it's not working.

[sandangel]

why don't we just mark Guard and Resolver as providedIn: 'root' when it's listed in canActivate and resolvers

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}