-
Notifications
You must be signed in to change notification settings - Fork 12k
Problems with --mobile and app-shell #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Your generated project came with Can you run |
@filipesilva by the way, I ran |
Ah I believe that to be the problem. The commit that added that specific dependency (e7d7ed8) got in May 18th, and was released in Can you do |
Yeah, and then I'll print out all the files again, will post. |
It worked! Now all the proper packages are included:
And:
|
But, new problems have arose, and it still won't
|
The comment above is an error shown after running
|
And all of this is done right after I installed |
That, unfortunately, is a very real problem and already reported in another issue: #958 This is the one @jeffbcross mentioned that someone was working on a fix, but I don't know much more about it at this moment. It should be fixed soon and included in the next beta since it's prioritized as critical. I'm going to close this issue for now as the original problem was solved, and the followup problem is a duplicate. |
@filipesilva great, thanks a lot for helping out on this one! I'll stay tuned on the other issue, but thanks again for taking the time to help me. |
No bother at all :D |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
(I am on OSX El Capitan, running
angular-cli: 0.1.0 node: 4.2.3 os: darwin x64
)I recently decided to try out Angular Mobile, and so I created an app through the CLI in mobile mode:
I then proceeded to install some
@angular-material2
components and started making an app shell.But when I tried to
ng serve
, it failed, telling me that it couldn't find@angular/app-shell
which I imported along with some Material elements inexample.component.ts
So then I looked in my
package.json
and system js setup, and angular cli build file, and found that@angular/app-shell
and service worker aren't even saved and installed! So then I looked at the "puppy-love" example app from Google I/O and in their package.json they are listed.So, to recreate the problem, I started a mobile app from scratch and here are the resulting files:
Here are the exact steps I took:
So there are the three main files, printed out in my terminal:
package.json
,angular-cli-build.js
, andsystem-config.ts
.Now let's compare them to the files from the
puppy-love
Google I/O example app:puppy-love-io/package.json:
puppy-love-io/angular-cli-build.js:
puppy-love-io/src/system-config.ts:
As you can see, there are several differences:
The
package.json
inpuppy-love
is different than mine. It requires several additional packages, including:Note
"@angular/app-shell"
, the package that was missing and caused myserve
failure.The same thing goes for the two different
system-config.ts
files. Mine is different thanpuppy-love
's, omitting@angular/app-shell',
fromconst barrels:string[]
.So I kind of see where my problem is, and I could probably fix it by manually requiring these files. But my real question is why these files weren't included, even though I used the
--mobile
flag atng new
. Did I do something wrong, or is there a problem with the CLI?Thanks for reviewing my issue, and I hope you guys have some feedback for me!
Colin Pirillo
@colindevs
The text was updated successfully, but these errors were encountered: