Skip to content

Commit fd512b8

Browse files
hanslvikerman
authored andcommitted
refactor: do not report errors if there is no errors to report
1 parent af6c6d4 commit fd512b8

File tree

1 file changed

+5
-2
lines changed
  • packages/angular_devkit/build_angular/plugins/webpack

1 file changed

+5
-2
lines changed

packages/angular_devkit/build_angular/plugins/webpack/analytics.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,11 @@ export class NgBuildAnalyticsPlugin {
123123
}
124124
protected _getDimensions(stats: Stats) {
125125
const dimensions: (string | number)[] = [];
126-
// Adding commas before and after so the regex are easier to define.
127-
dimensions[analytics.NgCliAnalyticsDimensions.BuildErrors] = `,${this._stats.errors.join()},`;
126+
127+
if (this._stats.errors.length) {
128+
// Adding commas before and after so the regex are easier to define filters.
129+
dimensions[analytics.NgCliAnalyticsDimensions.BuildErrors] = `,${this._stats.errors.join()},`;
130+
}
128131

129132
return dimensions;
130133
}

0 commit comments

Comments
 (0)