Skip to content

Commit fac9cca

Browse files
committed
fix(@angular-devkit/build-angular): don't override asset info when updating assets
Currently, we are overriding asset info instead of appending additional data to it.
1 parent f2598a4 commit fac9cca

File tree

3 files changed

+22
-9
lines changed

3 files changed

+22
-9
lines changed

packages/angular_devkit/build_angular/src/webpack/plugins/css-optimizer-plugin.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,10 @@ export class CssOptimizerPlugin {
7171

7272
if (cachedOutput) {
7373
await this.addWarnings(compilation, cachedOutput.warnings);
74-
compilation.updateAsset(name, cachedOutput.source, {
74+
compilation.updateAsset(name, cachedOutput.source, (assetInfo) => ({
75+
...assetInfo,
7576
minimized: true,
76-
});
77+
}));
7778
continue;
7879
}
7980
}
@@ -93,7 +94,10 @@ export class CssOptimizerPlugin {
9394
const optimizedAsset = map
9495
? new SourceMapSource(code, name, map)
9596
: new OriginalSource(code, name);
96-
compilation.updateAsset(name, optimizedAsset, { minimized: true });
97+
compilation.updateAsset(name, optimizedAsset, (assetInfo) => ({
98+
...assetInfo,
99+
minimized: true,
100+
}));
97101

98102
await cacheItem?.storePromise({
99103
source: optimizedAsset,

packages/angular_devkit/build_angular/src/webpack/plugins/javascript-optimizer-plugin.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,10 @@ export class JavaScriptOptimizerPlugin {
123123
>();
124124

125125
if (cachedOutput) {
126-
compilation.updateAsset(name, cachedOutput.source, {
126+
compilation.updateAsset(name, cachedOutput.source, (assetInfo) => ({
127+
...assetInfo,
127128
minimized: true,
128-
});
129+
}));
129130
continue;
130131
}
131132
}
@@ -209,7 +210,10 @@ export class JavaScriptOptimizerPlugin {
209210
const optimizedAsset = map
210211
? new SourceMapSource(code, name, map)
211212
: new OriginalSource(code, name);
212-
compilation.updateAsset(name, optimizedAsset, { minimized: true });
213+
compilation.updateAsset(name, optimizedAsset, (assetInfo) => ({
214+
...assetInfo,
215+
minimized: true,
216+
}));
213217

214218
return cacheItem?.storePromise({
215219
source: optimizedAsset,

packages/angular_devkit/build_angular/src/webpack/plugins/transfer-size-plugin.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,14 @@ export class TransferSizePlugin {
3939
actions.push(
4040
brotliCompressAsync(scriptAsset.source.source())
4141
.then((result) => {
42-
compilation.updateAsset(assetName, (s) => s, {
43-
estimatedTransferSize: result.length,
44-
});
42+
compilation.updateAsset(
43+
assetName,
44+
(s) => s,
45+
(assetInfo) => ({
46+
...assetInfo,
47+
estimatedTransferSize: result.length,
48+
}),
49+
);
4550
})
4651
.catch((error) => {
4752
compilation.warnings.push(

0 commit comments

Comments
 (0)