Skip to content

Commit dffa70a

Browse files
alan-agius4vikerman
authored andcommitted
test: refactor karma include spec
disable index of failing test and remove timeout which is less than the default
1 parent 5c823ce commit dffa70a

File tree

1 file changed

+24
-25
lines changed

1 file changed

+24
-25
lines changed

packages/angular_devkit/build_angular/test/karma/selected_spec_large.ts

+24-25
Original file line numberDiff line numberDiff line change
@@ -68,28 +68,6 @@ describe('Karma Builder', () => {
6868
await run.stop();
6969
});
7070

71-
beforeEach(() => {
72-
host.writeMultipleFiles({
73-
'src/app/services/test.service.spec.ts': `
74-
describe('TestService', () => {
75-
it('should succeed', () => {
76-
expect(true).toBe(true);
77-
});
78-
});`,
79-
'src/app/failing.service.spec.ts': `
80-
describe('FailingService', () => {
81-
it('should be ignored', () => {
82-
expect(true).toBe(false);
83-
});
84-
});`,
85-
'src/app/property.pipe.spec.ts': `
86-
describe('PropertyPipe', () => {
87-
it('should succeed', () => {
88-
expect(true).toBe(true);
89-
});
90-
});`,
91-
});
92-
});
9371
[
9472
{
9573
test: 'relative path from workspace to spec',
@@ -119,8 +97,29 @@ describe('Karma Builder', () => {
11997
test: 'glob with spec suffix',
12098
input: ['**/*.pipe.spec.ts', '**/*.pipe.spec.ts', '**/*test.service.spec.ts'],
12199
},
122-
].forEach(options => {
123-
it(`should work with ${options.test}`, async () => {
100+
].forEach((options, index) => {
101+
it(`should work with ${options.test} (${index})`, async () => {
102+
host.writeMultipleFiles({
103+
'src/app/services/test.service.spec.ts': `
104+
describe('TestService', () => {
105+
it('should succeed', () => {
106+
expect(true).toBe(true);
107+
});
108+
});`,
109+
'src/app/failing.service.spec.ts': `
110+
describe('FailingService', () => {
111+
it('should be ignored', () => {
112+
expect(true).toBe(false);
113+
});
114+
});`,
115+
'src/app/property.pipe.spec.ts': `
116+
describe('PropertyPipe', () => {
117+
it('should succeed', () => {
118+
expect(true).toBe(true);
119+
});
120+
});`,
121+
});
122+
124123
const overrides = {
125124
include: options.input,
126125
};
@@ -137,7 +136,7 @@ describe('Karma Builder', () => {
137136
await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
138137

139138
await run.stop();
140-
}, 30000);
139+
});
141140
});
142141
});
143142
});

0 commit comments

Comments
 (0)