Skip to content

Commit d736da1

Browse files
josephperrottdgp1130
authored andcommitted
build: set up post approval changes commit action
This action will enforce that all pull requests receive an approval from at least one googler on the final commit for the pull request. Historically, we have allowed all post approval changes regardless of authorship. Moving forward, with this change, we will only allow known googlers to perform post approval changes. When a post approval change occurs by a non-googler, the action will automatically rerequest a review from the latest googler who provided an approval on the change.
1 parent be67977 commit d736da1

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

.github/workflows/dev-infra.yml

+12-5
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,25 @@
11
name: DevInfra
22

3-
# Declare default permissions as read only.
4-
permissions:
5-
contents: read
6-
73
on:
84
pull_request_target:
95
types: [opened, synchronize, reopened]
106

7+
# Declare default permissions as read only.
8+
permissions:
9+
contents: read
10+
1111
jobs:
1212
labels:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2
16-
- uses: angular/dev-infra/github-actions/commit-message-based-labels@2a50bf4f37f041d8b88c743fae45d09b400e917e
16+
- uses: angular/dev-infra/github-actions/commit-message-based-labels@2a04da0754b050fb17d6cfc4a4b4fa8b5575ea86
17+
with:
18+
angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
19+
post_approval_changes:
20+
runs-on: ubuntu-latest
21+
steps:
22+
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2
23+
- uses: angular/dev-infra/github-actions/post-approval-changes@2a04da0754b050fb17d6cfc4a4b4fa8b5575ea86
1724
with:
1825
angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}

0 commit comments

Comments
 (0)