Skip to content

Commit cb3701f

Browse files
author
Zhicheng Wang
committed
fix(build): Don't specify the extract-css option as precondition for css sourcemaps
Instead, use `convertToAbsoluteUrls: true`. See <https://github.com/webpack-contrib/style-loader#converttoabsoluteurls>.
1 parent a24e644 commit cb3701f

File tree

1 file changed

+7
-3
lines changed
  • packages/@angular/cli/models/webpack-configs

1 file changed

+7
-3
lines changed

packages/@angular/cli/models/webpack-configs/styles.ts

+7-3
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export function getStylesConfig(wco: WebpackConfigOptions) {
3939
// style-loader does not support sourcemaps without absolute publicPath, so it's
4040
// better to disable them when not extracting css
4141
// https://github.com/webpack-contrib/style-loader#recommended-configuration
42-
const cssSourceMap = buildOptions.extractCss && buildOptions.sourcemaps;
42+
const cssSourceMap = buildOptions.sourcemaps;
4343

4444
// Minify/optimize css in production.
4545
const minimizeCss = buildOptions.target === 'production';
@@ -199,8 +199,12 @@ export function getStylesConfig(wco: WebpackConfigOptions) {
199199
const ret: any = {
200200
include: globalStylePaths,
201201
test,
202-
        use: buildOptions.extractCss ? ExtractTextPlugin.extract(extractTextPlugin)
203-
: ['style-loader', ...extractTextPlugin.use]
202+
use: buildOptions.extractCss ? ExtractTextPlugin.extract(extractTextPlugin) : [{
203+
loader: 'style-loader',
204+
options: {
205+
convertToAbsoluteUrls: cssSourceMap,
206+
},
207+
}, ...extractTextPlugin.use],
204208
};
205209
// Save the original options as arguments for eject.
206210
if (buildOptions.extractCss) {

0 commit comments

Comments
 (0)