Skip to content

Commit c889dd8

Browse files
authored
refactor(@angular-cli): get rid of ast-tools and base-href-webpack (#4411)
Those 2 packages were still using the wrong scope (@angular-cli) and were not used by anyone outside the CLI. Just moving the code in the main package is enough.
1 parent 9fcf10a commit c889dd8

28 files changed

+15
-123
lines changed

packages/@angular-cli/ast-tools/package.json

-32
This file was deleted.

packages/@angular-cli/ast-tools/tsconfig.json

-24
This file was deleted.

packages/@angular-cli/base-href-webpack/package.json

-25
This file was deleted.

packages/@angular-cli/base-href-webpack/tsconfig.json

-27
This file was deleted.

packages/@angular/cli/blueprints/component/index.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import {NodeHost} from '../../lib/ast-tools';
2+
13
const path = require('path');
24
const fs = require('fs');
35
const chalk = require('chalk');
@@ -7,7 +9,6 @@ const findParentModule = require('../../utilities/find-parent-module').default;
79
const getFiles = Blueprint.prototype.files;
810
const stringUtils = require('ember-cli-string-utils');
911
const astUtils = require('../../utilities/ast-utils');
10-
const NodeHost = require('@angular-cli/ast-tools').NodeHost;
1112

1213
export default Blueprint.extend({
1314
description: '',

packages/@angular/cli/blueprints/directive/index.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1+
import {NodeHost} from '../../lib/ast-tools';
2+
13
const path = require('path');
24
const fs = require('fs');
35
const chalk = require('chalk');
46
const dynamicPathParser = require('../../utilities/dynamic-path-parser');
57
const stringUtils = require('ember-cli-string-utils');
68
const astUtils = require('../../utilities/ast-utils');
79
const findParentModule = require('../../utilities/find-parent-module').default;
8-
const NodeHost = require('@angular-cli/ast-tools').NodeHost;
910
const Blueprint = require('../../ember-cli/lib/models/blueprint');
1011
const getFiles = Blueprint.prototype.files;
1112

packages/@angular/cli/blueprints/pipe/index.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1+
import {NodeHost} from '../../lib/ast-tools';
2+
13
const path = require('path');
24
const fs = require('fs');
35
const chalk = require('chalk');
46
const dynamicPathParser = require('../../utilities/dynamic-path-parser');
57
const stringUtils = require('ember-cli-string-utils');
68
const astUtils = require('../../utilities/ast-utils');
79
const findParentModule = require('../../utilities/find-parent-module').default;
8-
const NodeHost = require('@angular-cli/ast-tools').NodeHost;
910
const Blueprint = require('../../ember-cli/lib/models/blueprint');
1011
const getFiles = Blueprint.prototype.files;
1112

packages/@angular/cli/blueprints/service/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1+
import {NodeHost} from '../../lib/ast-tools';
12
import { oneLine } from 'common-tags';
23

34
const path = require('path');
45
const fs = require('fs');
56
const chalk = require('chalk');
67
const dynamicPathParser = require('../../utilities/dynamic-path-parser');
78
const Blueprint = require('../../ember-cli/lib/models/blueprint');
8-
const NodeHost = require('@angular-cli/ast-tools').NodeHost;
99
const stringUtils = require('ember-cli-string-utils');
1010
const astUtils = require('../../utilities/ast-utils');
1111
const getFiles = Blueprint.prototype.files;

packages/@angular/cli/models/webpack-configs/common.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as webpack from 'webpack';
22
import * as path from 'path';
33
import { GlobCopyWebpackPlugin } from '../../plugins/glob-copy-webpack-plugin';
44
import { packageChunkSort } from '../../utilities/package-chunk-sort';
5-
import { BaseHrefWebpackPlugin } from '@angular-cli/base-href-webpack';
5+
import { BaseHrefWebpackPlugin } from '../../lib/base-href-webpack';
66
import { extraEntryParser, lazyChunksFilter, getOutputHashFormat } from './utils';
77
import { WebpackConfigOptions } from '../webpack-config';
88

packages/@angular/cli/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,10 @@
2626
},
2727
"homepage": "https://github.com/angular/angular-cli",
2828
"dependencies": {
29-
"@angular-cli/ast-tools": "^1.0.14",
30-
"@angular-cli/base-href-webpack": "^1.0.14",
3129
"@angular/compiler": "^2.3.1",
3230
"@angular/compiler-cli": "^2.3.1",
3331
"@angular/core": "^2.3.1",
32+
"@angular/tsc-wrapped": "^0.5.0",
3433
"@ngtools/json-schema": "^1.0.0",
3534
"@ngtools/webpack": "^1.2.3",
3635
"async": "^2.1.4",
@@ -74,6 +73,7 @@
7473
"resolve": "^1.1.7",
7574
"rimraf": "^2.5.3",
7675
"rsvp": "^3.0.17",
76+
"rxjs": "^5.0.1",
7777
"sass-loader": "^4.1.1",
7878
"script-loader": "^0.7.0",
7979
"semver": "^5.1.0",

packages/@angular/cli/tsconfig.json

-3
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@
2020
],
2121
"baseUrl": "",
2222
"paths": {
23-
"@angular-cli/ast-tools": [ "../../../dist/@angular-cli/ast-tools/src" ],
24-
"@angular-cli/base-href-webpack": [ "../../../dist/@angular-cli/base-href-webpack/src" ],
25-
"@angular-cli/version": [ "../../../dist/@angular-cli/version/src" ],
2623
"@ngtools/json-schema": [ "../../../dist/@ngtools/json-schema/src" ],
2724
"@ngtools/webpack": [ "../../../dist/@ngtools/webpack/src" ]
2825
}

packages/@angular/cli/utilities/ast-utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ export {
1010
addDeclarationToModule,
1111
addProviderToModule,
1212
addExportToModule
13-
} from '@angular-cli/ast-tools';
13+
} from '../lib/ast-tools';

packages/@angular/cli/utilities/change.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ export {
55
InsertChange,
66
RemoveChange,
77
ReplaceChange
8-
} from '@angular-cli/ast-tools';
8+
} from '../lib/ast-tools';

packages/@angular/cli/utilities/module-resolver.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as dependentFilesUtils from './get-dependent-files';
66

77

88
import {Change, ReplaceChange} from './change';
9-
import {NodeHost, Host} from '@angular-cli/ast-tools';
9+
import {NodeHost, Host} from '../lib/ast-tools';
1010

1111
/**
1212
* Rewrites import module of dependent files when the file is moved.

packages/@angular/cli/utilities/route-utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ export {
88
confirmComponentExport,
99
resolveComponentPath,
1010
applyChanges
11-
} from '@angular-cli/ast-tools';
11+
} from '../lib/ast-tools';

tests/e2e/utils/ast.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {
22
insertImport as _insertImport,
33
addImportToModule as _addImportToModule,
44
NodeHost
5-
} from '@angular-cli/ast-tools';
5+
} from '../../../packages/@angular/cli/lib/ast-tools';
66

77

88
export function insertImport(file: string, symbol: string, module: string) {

0 commit comments

Comments
 (0)