test: use random devserver ports

jbedard · jbedard · commit c74e33eef1bb · 2022-07-25T12:44:55.000-07:00
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/specs/works_spec.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/specs/works_spec.ts
@@ -34,7 +34,7 @@ describe('Dev Server Builder', () => {
     expect(output.success).toBe(true);
 
     // When webpack-dev-server doesn't have `contentBase: false`, this will serve the repo README.
-    const response = await fetch('http://localhost:4200/README.md', {
+    const response = await fetch(`http://localhost:${output.port}/README.md`, {
       headers: {
         'Accept': 'text/html',
       },
diff --git a/packages/angular_devkit/build_angular/test/hello-world-app/protractor.conf.js b/packages/angular_devkit/build_angular/test/hello-world-app/protractor.conf.js
@@ -23,7 +23,7 @@ exports.config = {
     },
   },
   directConnect: true,
-  baseUrl: 'http://localhost:4200/',
+  baseUrl: 'http://localhost:0/',
   framework: 'jasmine',
   jasmineNodeOpts: {
     showColors: true,
diff --git a/tests/legacy-cli/e2e/assets/12.0-project/e2e/protractor.conf.js b/tests/legacy-cli/e2e/assets/12.0-project/e2e/protractor.conf.js
@@ -14,7 +14,7 @@ exports.config = {
     browserName: 'chrome',
   },
   directConnect: true,
-  baseUrl: 'http://localhost:4200/',
+  baseUrl: 'http://localhost:0/',
   framework: 'jasmine',
   jasmineNodeOpts: {
     showColors: true,
diff --git a/tests/legacy-cli/e2e/assets/13.0-project/e2e/protractor.conf.js b/tests/legacy-cli/e2e/assets/13.0-project/e2e/protractor.conf.js
@@ -14,7 +14,7 @@ exports.config = {
     browserName: 'chrome',
   },
   directConnect: true,
-  baseUrl: 'http://localhost:4200/',
+  baseUrl: 'http://localhost:0/',
   framework: 'jasmine',
   jasmineNodeOpts: {
     showColors: true,
diff --git a/tests/legacy-cli/e2e/tests/basic/e2e.ts b/tests/legacy-cli/e2e/tests/basic/e2e.ts
@@ -5,6 +5,6 @@ export default async function () {
   await expectToFail(() => silentNg('e2e', 'test-project', '--dev-server-target='));
 
   // These should work.
-  await silentNg('e2e', 'test-project');
-  await silentNg('e2e', 'test-project', '--dev-server-target=test-project:serve');
+  await silentNg('e2e', '--port=0', 'test-project');
+  await silentNg('e2e', '--port=0', 'test-project', '--dev-server-target=test-project:serve');
 }
diff --git a/tests/legacy-cli/e2e/tests/basic/standalone.ts b/tests/legacy-cli/e2e/tests/basic/standalone.ts
@@ -54,5 +54,5 @@ export default async function () {
   await ng('build');
 
   // Perform the default E2E tests
-  await ng('e2e', 'test-project');
+  await ng('e2e', '--port=0', 'test-project');
 }
diff --git a/tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts b/tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts
@@ -98,6 +98,6 @@ export default async function () {
   // Both Ivy and View Engine should support it.
   await replaceLoadChildren(`() => import('./lazy/lazy.module').then(m => m.LazyModule)`);
 
-  await ng('e2e');
-  await ng('e2e', '--configuration=production');
+  await ng('e2e', '--port=0');
+  await ng('e2e', '--port=0', '--configuration=production');
 }
diff --git a/tests/legacy-cli/e2e/tests/build/library/lib-consumption-full-aot.ts b/tests/legacy-cli/e2e/tests/build/library/lib-consumption-full-aot.ts
@@ -8,6 +8,6 @@ export default async function () {
   await ng('build', 'my-lib', '--configuration=development');
 
   // Check that the e2e succeeds prod and non prod mode
-  await ng('e2e', '--configuration=production');
-  await ng('e2e', '--configuration=development');
+  await ng('e2e', '--port=0', '--configuration=production');
+  await ng('e2e', '--port=0', '--configuration=development');
 }
diff --git a/tests/legacy-cli/e2e/tests/build/library/lib-consumption-full-jit.ts b/tests/legacy-cli/e2e/tests/build/library/lib-consumption-full-jit.ts
@@ -17,8 +17,8 @@ export default async function () {
   });
 
   // Check that the e2e succeeds prod and non prod mode
-  await ng('e2e', '--configuration=production');
-  await ng('e2e', '--configuration=development');
+  await ng('e2e', '--port=0', '--configuration=production');
+  await ng('e2e', '--port=0', '--configuration=development');
 
   // Validate that sourcemaps for the library exists.
   await ng('build', '--configuration=development');
diff --git a/tests/legacy-cli/e2e/tests/build/library/lib-consumption-partial-aot.ts b/tests/legacy-cli/e2e/tests/build/library/lib-consumption-partial-aot.ts
@@ -8,6 +8,6 @@ export default async function () {
   await ng('build', 'my-lib', '--configuration=production');
 
   // Check that the e2e succeeds prod and non prod mode
-  await ng('e2e', '--configuration=production');
-  await ng('e2e', '--configuration=development');
+  await ng('e2e', '--port=0', '--configuration=production');
+  await ng('e2e', '--port=0', '--configuration=development');
 }
diff --git a/tests/legacy-cli/e2e/tests/build/library/lib-consumption-partial-jit.ts b/tests/legacy-cli/e2e/tests/build/library/lib-consumption-partial-jit.ts
@@ -16,6 +16,6 @@ export default async function () {
   });
 
   // Check that the e2e succeeds prod and non prod mode
-  await ng('e2e', '--configuration=production');
-  await ng('e2e', '--configuration=development');
+  await ng('e2e', '--port=0', '--configuration=production');
+  await ng('e2e', '--port=0', '--configuration=development');
 }
diff --git a/tests/legacy-cli/e2e/tests/build/material.ts b/tests/legacy-cli/e2e/tests/build/material.ts
@@ -77,5 +77,5 @@ export default async function () {
   `,
   );
 
-  await ng('e2e', '--configuration=production');
+  await ng('e2e', '--port=0', '--configuration=production');
 }
diff --git a/tests/legacy-cli/e2e/tests/build/worker.ts b/tests/legacy-cli/e2e/tests/build/worker.ts
@@ -51,5 +51,5 @@ export default async function () {
   `,
   );
 
-  await ng('e2e');
+  await ng('e2e', '--port=0');
 }
diff --git a/tests/legacy-cli/e2e/tests/commands/e2e/e2e-and-serve.ts b/tests/legacy-cli/e2e/tests/commands/e2e/e2e-and-serve.ts
@@ -5,7 +5,7 @@ export default async function () {
   try {
     // Should run side-by-side with `ng serve`
     await ngServe();
-    await silentNg('e2e');
+    await silentNg('e2e', '--port=0');
   } finally {
     killAllProcesses();
   }
diff --git a/tests/legacy-cli/e2e/tests/commands/e2e/multiple-specs.ts b/tests/legacy-cli/e2e/tests/commands/e2e/multiple-specs.ts
@@ -8,6 +8,7 @@ export default async function () {
 
   await silentNg(
     'e2e',
+    '--port=0',
     'test-project',
     '--specs',
     './e2e/renamed-app.e2e-spec.ts',
diff --git a/tests/legacy-cli/e2e/tests/commands/e2e/protractor-config.ts b/tests/legacy-cli/e2e/tests/commands/e2e/protractor-config.ts
@@ -4,5 +4,10 @@ import { silentNg } from '../../../utils/process';
 export default async function () {
   // Should accept different config file
   await moveFile('./e2e/protractor.conf.js', './e2e/renamed-protractor.conf.js');
-  await silentNg('e2e', 'test-project', '--protractor-config=e2e/renamed-protractor.conf.js');
+  await silentNg(
+    'e2e',
+    '--port=0',
+    'test-project',
+    '--protractor-config=e2e/renamed-protractor.conf.js',
+  );
 }
diff --git a/tests/legacy-cli/e2e/tests/commands/e2e/suite.ts b/tests/legacy-cli/e2e/tests/commands/e2e/suite.ts
@@ -12,5 +12,5 @@ export default async function () {
         },
     `,
   );
-  await silentNg('e2e', 'test-project', '--suite=app');
+  await silentNg('e2e', '--port=0', 'test-project', '--suite=app');
 }
diff --git a/tests/legacy-cli/e2e/tests/i18n/ivy-localize-es2015-e2e.ts b/tests/legacy-cli/e2e/tests/i18n/ivy-localize-es2015-e2e.ts
@@ -7,6 +7,6 @@ export default async function () {
 
   for (const { lang } of langTranslations) {
     // Execute Application E2E tests with dev server
-    await ng('e2e', `--configuration=${lang}`, '--port=0');
+    await ng('e2e', '--port=0', `--configuration=${lang}`, '--port=0');
   }
 }
diff --git a/tests/legacy-cli/e2e/tests/i18n/ivy-localize-locale-data-augment.ts b/tests/legacy-cli/e2e/tests/i18n/ivy-localize-locale-data-augment.ts
@@ -40,6 +40,6 @@ export default async function () {
     await expectFileToMatch(`${outputPath}/vendor.js`, lang);
 
     // Execute Application E2E tests with dev server
-    await ng('e2e', `--configuration=${lang}`, '--port=0');
+    await ng('e2e', '--port=0', `--configuration=${lang}`);
   }
 }
diff --git a/tests/legacy-cli/e2e/tests/misc/browsers.ts b/tests/legacy-cli/e2e/tests/misc/browsers.ts
@@ -46,6 +46,7 @@ export default async function () {
     // Execute application's E2E tests with SauceLabs
     await ng(
       'e2e',
+      '--port=0',
       'test-project',
       '--protractor-config=e2e/protractor-saucelabs.conf.js',
       '--dev-server-target=',
diff --git a/tests/legacy-cli/e2e/tests/misc/e2e-host.ts b/tests/legacy-cli/e2e/tests/misc/e2e-host.ts
@@ -19,6 +19,6 @@ export default async function () {
     appArchitect.serve.options.host = host;
   });
 
-  await ng('e2e');
-  await ng('e2e', '--host', host);
+  await ng('e2e', '--port=0');
+  await ng('e2e', '--port=0', '--host', host);
 }
diff --git a/tests/legacy-cli/e2e/tests/misc/http-headers.ts b/tests/legacy-cli/e2e/tests/misc/http-headers.ts
@@ -26,7 +26,7 @@ export default async function () {
 
   let errorMessage: string | null = null;
   try {
-    await ng('e2e');
+    await ng('e2e', '--port=0');
   } catch (error) {
     errorMessage = error instanceof Error ? error.message : null;
   }
diff --git a/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts b/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts
@@ -165,5 +165,5 @@ export default async function () {
   });
 
   // Run the e2e tests against a production build.
-  await ng('e2e', '--configuration=production');
+  await ng('e2e', '--port=0', '--configuration=production');
 }
diff --git a/tests/legacy-cli/e2e/tests/misc/trusted-types.ts b/tests/legacy-cli/e2e/tests/misc/trusted-types.ts
@@ -69,7 +69,7 @@ export default async function () {
     });
 
     try {
-      await ng('e2e');
+      await ng('e2e', '--port=0');
     } catch (error) {
       console.error(`Test case AOT ${aot} with CSP header ${csp} failed.`);
       throw error;
diff --git a/tests/legacy-cli/e2e/tests/update/update.ts b/tests/legacy-cli/e2e/tests/update/update.ts
@@ -79,8 +79,8 @@ export default async function () {
   await ng('generate', 'component', 'my-comp');
   await ng('test', '--watch=false');
 
-  await ng('e2e');
-  await ng('e2e', '--configuration=production');
+  await ng('e2e', '--port=0');
+  await ng('e2e', '--port=0', '--configuration=production');
 
   // Verify project now creates bundles
   await noSilentNg('build', '--configuration=production');

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,6 @@ export default async function () {`
`5`	`5`	`await expectToFail(() => silentNg('e2e', 'test-project', '--dev-server-target='));`
`6`	`6`
`7`	`7`	`// These should work.`
`8`		`- await silentNg('e2e', 'test-project');`
`9`		`- await silentNg('e2e', 'test-project', '--dev-server-target=test-project:serve');`
	`8`	`+ await silentNg('e2e', '--port=0', 'test-project');`
	`9`	`+ await silentNg('e2e', '--port=0', 'test-project', '--dev-server-target=test-project:serve');`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,5 +54,5 @@ export default async function () {`
`54`	`54`	`await ng('build');`
`55`	`55`
`56`	`56`	`// Perform the default E2E tests`
`57`		`- await ng('e2e', 'test-project');`
	`57`	`+ await ng('e2e', '--port=0', 'test-project');`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,6 @@ export default async function () {`
`98`	`98`	`// Both Ivy and View Engine should support it.`
`99`	`99`	await replaceLoadChildren(`() => import('./lazy/lazy.module').then(m => m.LazyModule)`);
`100`	`100`
`101`		`- await ng('e2e');`
`102`		`- await ng('e2e', '--configuration=production');`
	`101`	`+ await ng('e2e', '--port=0');`
	`102`	`+ await ng('e2e', '--port=0', '--configuration=production');`
`103`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,6 @@ export default async function () {`
`8`	`8`	`await ng('build', 'my-lib', '--configuration=development');`
`9`	`9`
`10`	`10`	`// Check that the e2e succeeds prod and non prod mode`
`11`		`- await ng('e2e', '--configuration=production');`
`12`		`- await ng('e2e', '--configuration=development');`
	`11`	`+ await ng('e2e', '--port=0', '--configuration=production');`
	`12`	`+ await ng('e2e', '--port=0', '--configuration=development');`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,6 @@ export default async function () {`
`16`	`16`	`});`
`17`	`17`
`18`	`18`	`// Check that the e2e succeeds prod and non prod mode`
`19`		`- await ng('e2e', '--configuration=production');`
`20`		`- await ng('e2e', '--configuration=development');`
	`19`	`+ await ng('e2e', '--port=0', '--configuration=production');`
	`20`	`+ await ng('e2e', '--port=0', '--configuration=development');`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,5 +77,5 @@ export default async function () {`
`77`	`77`	`,
`78`	`78`	`);`
`79`	`79`
`80`		`- await ng('e2e', '--configuration=production');`
	`80`	`+ await ng('e2e', '--port=0', '--configuration=production');`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,5 +51,5 @@ export default async function () {`
`51`	`51`	`,
`52`	`52`	`);`
`53`	`53`
`54`		`- await ng('e2e');`
	`54`	`+ await ng('e2e', '--port=0');`
`55`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ export default async function () {`
`5`	`5`	`try {`
`6`	`6`	// Should run side-by-side with `ng serve`
`7`	`7`	`await ngServe();`
`8`		`- await silentNg('e2e');`
	`8`	`+ await silentNg('e2e', '--port=0');`
`9`	`9`	`} finally {`
`10`	`10`	`killAllProcesses();`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,5 @@ export default async function () {`
`12`	`12`	`},`
`13`	`13`	`,
`14`	`14`	`);`
`15`		`- await silentNg('e2e', 'test-project', '--suite=app');`
	`15`	`+ await silentNg('e2e', '--port=0', 'test-project', '--suite=app');`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,6 @@ export default async function () {`
`7`	`7`
`8`	`8`	`for (const { lang } of langTranslations) {`
`9`	`9`	`// Execute Application E2E tests with dev server`
`10`		- await ng('e2e', `--configuration=${lang}`, '--port=0');
	`10`	+ await ng('e2e', '--port=0', `--configuration=${lang}`, '--port=0');
`11`	`11`	`}`
`12`	`12`	`}`