Skip to content

Commit c68578b

Browse files
alan-agius4mgechev
authored andcommitted
test: disable e2e that are not support by ngcc api
1 parent 4595d9c commit c68578b

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

tests/legacy-cli/e2e/tests/build/script-target.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,14 @@ export default function () {
88
// TODO(architect): Delete this test. It is now in devkit/build-angular.
99

1010
// Skip this test in Angular 2, it had different bundles.
11-
if (getGlobalVariable('argv').ng2) {
11+
if (getGlobalVariable('argv')['ng2']) {
12+
return Promise.resolve();
13+
}
14+
15+
if (getGlobalVariable('argv')['ivy']) {
16+
// todo: enable when NGCC supports this.
17+
// At the moment, we re-run NGCC with a different 'propertiesToConsider'.
18+
// https://angular-team.atlassian.net/browse/FW-1211
1219
return Promise.resolve();
1320
}
1421

tests/legacy-cli/e2e/tests/misc/module-resolution.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,17 @@ import { appendToFile, createDir, moveFile, prependToFile } from '../../utils/fs
22
import { ng, silentNpm } from '../../utils/process';
33
import { updateJsonFile } from '../../utils/project';
44
import { expectToFail } from '../../utils/utils';
5+
import { getGlobalVariable } from '../../utils/env';
56

67

78
export default async function () {
9+
if (getGlobalVariable('argv')['ivy']) {
10+
// todo: enable when NGCC supports this.
11+
// this test is not yet supported under IVY because can only transform packages from a single basePaths.
12+
// https://angular-team.atlassian.net/browse/FW-1204
13+
return;
14+
}
15+
816
await updateJsonFile('tsconfig.json', tsconfig => {
917
tsconfig.compilerOptions.paths = {
1018
'*': ['./node_modules/*'],

0 commit comments

Comments
 (0)