build: exclude nested node_modules laid out by yarn workspaces from all globs

Author: gregmagolan

packages/angular/cli/BUILD.bazel

@@ -18,8 +18,12 @@ package(default_visibility = ["//visibility:public"])
 ts_library(
     name = "angular-cli",
     srcs = glob(
-        ["**/*.ts"],
-        exclude = ["**/*_spec.ts"],
+        include = ["**/*.ts"],
+        exclude = [
+            "**/*_spec.ts",
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
     ) + [
         "//packages/angular/cli:lib/config/schema.ts",
         "//packages/angular/cli:commands/analytics.ts",
@@ -42,11 +46,17 @@ ts_library(
         "//packages/angular/cli:commands/run.ts",
         "//packages/angular/cli:commands/xi18n.ts",
     ],
-    data = glob([
-        "bin/**/*",
-        "**/*.json",
-        "**/*.md",
-    ]),
+    data = glob(
+        include = [
+            "bin/**/*",
+            "**/*.json",
+            "**/*.md",
+        ],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
+    ),
     module_name = "@angular/cli",
     # strict_checks = False,
     deps = [
@@ -228,7 +238,13 @@ ts_json_schema(
 ts_library(
     name = "angular-cli_test_lib",
     testonly = True,
-    srcs = glob(["**/*_spec.ts"]),
+    srcs = glob(
+        include = ["**/*_spec.ts"],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
+    ),
     # strict_checks = False,
     deps = [
         ":angular-cli",

packages/angular/pwa/BUILD.bazel

@@ -25,6 +25,8 @@ ts_library(
         exclude = [
             "pwa/files/**/*",
             "**/*_spec.ts",
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
         ],
     ) + [
         "//packages/angular/pwa:pwa/schema.ts",

packages/angular_devkit/architect/BUILD.bazel

@@ -49,7 +49,13 @@ ts_library(
         "//packages/angular_devkit/architect:src/progress-schema.ts",
     ],
     # strict_checks = False,
-    data = glob(["**/*.json"]),
+    data = glob(
+        include = ["**/*.json"],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
+    ),
     module_name = "@angular-devkit/architect",
     module_root = "src/index.d.ts",
     deps = [

packages/angular_devkit/build_ng_packagr/BUILD.bazel

@@ -26,13 +26,11 @@ ts_library(
     ) + [
         "//packages/angular_devkit/build_ng_packagr:src/build/schema.ts",
     ],
-    data = glob(
-        include = [
-            "package.json",
-            "builders.json",
-            "src/build/schema.json",
-        ],
-    ),
+    data = [
+        "builders.json",
+        "package.json",
+        "src/build/schema.json",
+    ],
     module_name = "@angular-devkit/build-ng-packagr",
     module_root = "src/index.d.ts",
     deps = [

packages/angular_devkit/build_optimizer/BUILD.bazel

@@ -24,12 +24,10 @@ ts_library(
             "src/**/*_benchmark.ts",
         ],
     ),
-    data = glob(
-        include = [
-            "package.json",
-            "webpack-loader/package.json",
-        ],
-    ),
+    data = [
+        "package.json",
+        "webpack-loader/package.json",
+    ],
     module_name = "@angular-devkit/build-optimizer",
     module_root = "src/index.d.ts",
     deps = [

packages/angular_devkit/build_webpack/BUILD.bazel

@@ -35,14 +35,12 @@ ts_library(
         "//packages/angular_devkit/build_webpack:src/webpack/schema.ts",
         "//packages/angular_devkit/build_webpack:src/webpack-dev-server/schema.ts",
     ],
-    data = glob(
-        include = [
-            "package.json",
-            "builders.json",
-            "src/webpack/schema.json",
-            "src/webpack-dev-server/schema.json",
-        ],
-    ),
+    data = [
+        "builders.json",
+        "package.json",
+        "src/webpack-dev-server/schema.json",
+        "src/webpack/schema.json",
+    ],
     module_name = "@angular-devkit/build-webpack",
     module_root = "src/index.d.ts",
     deps = [

packages/angular_devkit/core/BUILD.bazel

@@ -25,7 +25,11 @@ ts_library(
             "src/**/*_benchmark.ts",
         ],
     ),
-    data = glob(["**/*.json"]) + [
+    data = glob(
+        include = ["**/*.json"],
+        # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+        exclude = ["node_modules/**"],
+    ) + [
         "//packages/angular_devkit/core/third_party/github.com/chalk/supports-color",
     ],
     module_name = "@angular-devkit/core",

packages/angular_devkit/schematics/BUILD.bazel

@@ -27,7 +27,13 @@ ts_library(
     ),
     # The attribute below is needed in g3 to turn off strict typechecking
     # strict_checks = False,
-    data = glob(["**/*.json"]),
+    data = glob(
+        include = ["**/*.json"],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
+    ),
     module_name = "@angular-devkit/schematics",
     module_root = "src/index.d.ts",
     deps = [

packages/angular_devkit/schematics_cli/BUILD.bazel

@@ -22,7 +22,13 @@ ts_library(
     ),
     # The attribute below is needed in g3 to turn off strict typechecking
     # strict_checks = False,
-    data = glob(["**/*.json"]),
+    data = glob(
+        include = ["**/*.json"],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
+    ),
     module_name = "@angular-devkit/schematics-cli",
     module_root = "bin/schematics.d.ts",
     deps = [

packages/schematics/angular/BUILD.bazel

@@ -21,7 +21,13 @@ ALL_SCHEMA_TARGETS = [
         x,
         x.replace("/", "_").replace("-", "_").replace(".json", ""),
     )
-    for x in glob(["*/schema.json"])
+    for x in glob(
+        include = ["*/schema.json"],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
+    )
 ]
 
 # Create all the targets.
@@ -45,6 +51,8 @@ ts_library(
             "*/other-files/**/*.ts",
             # Exclude test helpers.
             "utility/test/**/*.ts",
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
         ],
     ) + [
         "//packages/schematics/angular:" + src.replace(".json", ".ts")
@@ -60,6 +68,10 @@ ts_library(
             "*/files/**/*",
             "*/other-files/**/*",
         ],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
     ),
     module_name = "@schematics/angular",
     deps = [
@@ -92,6 +104,10 @@ ts_library(
             "**/*_spec.ts",
             "utility/test/**/*.ts",
         ],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
     ),
     # @external_begin
     deps = [

packages/schematics/schematics/BUILD.bazel

@@ -22,6 +22,8 @@ ts_library(
             "schematic/files/**",
             "blank/project-files/**",
             "blank/schematic-files/**",
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
         ],
     ) + [
         "//packages/schematics/schematics:blank/schema.ts",

packages/schematics/update/BUILD.bazel

@@ -22,6 +22,8 @@ ts_library(
         exclude = [
             "**/*_spec.ts",
             "**/*_benchmark.ts",
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
         ],
     ) + [
         "//packages/schematics/update:update/schema.ts",
@@ -53,11 +55,21 @@ ts_json_schema(
 ts_library(
     name = "update_test_lib",
     testonly = True,
-    srcs = glob(["**/*_spec.ts"]),
+    srcs = glob(
+        include = ["**/*_spec.ts"],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
+    ),
     data = glob(
         include = [
             "**/*.json",
         ],
+        exclude = [
+            # NB: we need to exclude the nested node_modules that is laid out by yarn workspaces
+            "node_modules/**",
+        ],
     ),
     # @external_begin
     deps = [