Skip to content

Commit b5758ac

Browse files
clydindgp1130
authored andcommitted
ci: disable redundant Angular bot size check
The E2E test suite contains a production build test (`build/prod-build`) that performs a size comparison check to ensure a production build of a newly generated application stays within 10% of a predefined value (currently 124,000 bytes). As a result of this preexisting check, the need to perform another check that involves the added complexity of Github status hooks and API calls is currently not needed.
1 parent 73bda26 commit b5758ac

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/angular-robot.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ triage:
9393

9494
# Size checking
9595
size:
96+
# Size checking for production build is performed via the E2E test `build/prod-build`
97+
disabled: true
9698
circleCiStatusName: 'ci/circleci: e2e-cli'
9799
maxSizeIncrease: 10000
98100
comment: false

tests/legacy-cli/e2e/tests/build/prod-build.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ function verifySize(bundle: string, baselineBytes: number) {
2424
}
2525

2626
export default async function () {
27-
// TODO(architect): Delete this test. It is now in devkit/build-angular.
28-
2927
// Can't use the `ng` helper because somewhere the environment gets
3028
// stuck to the first build done
3129
const bootstrapRegExp = /bootstrapModule\([_a-zA-Z]+[0-9]*\)\./;

0 commit comments

Comments
 (0)