Skip to content

Commit b53b4e6

Browse files
alan-agius4clydin
authored andcommitted
build: disable UT testing multiple node versions
With this change we disable running UTs on multiple node.js versions. This is mainly an interim solution until we find the root cause of the memory increase and OOM errors during bazel test. During this change I also noticed that the toolchain was configured incorrectly. Setting the toolchain to use Node.js 16 causes the App-shell tests to fail when used under Bazel. See: https://app.circleci.com/pipelines/github/angular/angular-cli/25009/workflows/4ea86ec8-d1f7-4c91-8810-76f10f8e878c/jobs/325982 (cherry picked from commit 167887d)
1 parent 67b3a08 commit b53b4e6

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

tools/toolchain_info.bzl

+8-6
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
# the order will match against the order in the TOOLCHAIN_VERSION list.
55
TOOLCHAINS_NAMES = [
66
"node14",
7-
"node16",
7+
# TODO enable one we know more why there is a memory usage increase and app-shell tests work with Node.js 16.
8+
# "node16",
89
]
910

1011
# this is the list of toolchains that should be used and are registered with nodejs_register_toolchains in the WORKSPACE file
@@ -14,11 +15,12 @@ TOOLCHAINS_VERSIONS = [
1415
"@bazel_tools//src/conditions:darwin": "@node14_darwin_amd64//:node_toolchain",
1516
"@bazel_tools//src/conditions:windows": "@node14_windows_amd64//:node_toolchain",
1617
}),
17-
select({
18-
"@bazel_tools//src/conditions:linux_x86_64": "@node14_linux_amd64//:node_toolchain",
19-
"@bazel_tools//src/conditions:darwin": "@node14_darwin_amd64//:node_toolchain",
20-
"@bazel_tools//src/conditions:windows": "@node14_windows_amd64//:node_toolchain",
21-
}),
18+
# TODO enable one we know more why there is a memory usage increase and app-shell tests work with Node.js 16.
19+
# select({
20+
# "@bazel_tools//src/conditions:linux_x86_64": "@node16_linux_amd64//:node_toolchain",
21+
# "@bazel_tools//src/conditions:darwin": "@node16_darwin_amd64//:node_toolchain",
22+
# "@bazel_tools//src/conditions:windows": "@node16_windows_amd64//:node_toolchain",
23+
# }),
2224
]
2325

2426
# A default toolchain for use when only one is necessary

0 commit comments

Comments
 (0)