fix(@angular/cli): ensure git repository is clean before updates

If not asking for update status then this change checks for a clean git repository before proceeding.  This allows the user to easily reset any changes from the update and avoid any developer code changes from being mixed with update changes.

Author: clydin

packages/angular/cli/commands/update-impl.ts

@@ -5,6 +5,7 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+import { execSync } from 'child_process';
 import * as path from 'path';
 import * as semver from 'semver';
 import { Arguments, Option } from '../models/interface';
@@ -80,6 +81,16 @@ export class UpdateCommand extends SchematicCommand<UpdateCommandSchema> {
       return 1;
     }
 
+    // If not asking for status then check for a clean git repository.
+    // This allows the user to easily reset any changes from the update.
+    if ((packages.length !== 0 || options.all) && !this.checkCleanGit()) {
+      this.logger.error(
+        'Repository is not clean.  Please commit or stash any changes before updating.',
+      );
+
+      return 2;
+    }
+
     const packageManager = getPackageManager(this.workspace.root);
     this.logger.info(`Using package manager: '${packageManager}'`);
 
@@ -266,4 +277,14 @@ export class UpdateCommand extends SchematicCommand<UpdateCommandSchema> {
       },
     });
   }
+
+  checkCleanGit() {
+    try {
+      const result = execSync('git status --porcelain', { encoding: 'utf8', stdio: 'pipe' });
+
+      return result.trim().length === 0;
+    } catch {
+      return true;
+    }
+  }
 }

tests/legacy-cli/e2e/tests/misc/update-git-clean.ts

@@ -0,0 +1,12 @@
+import { appendToFile } from '../../utils/fs';
+import { ng } from '../../utils/process';
+import { expectToFail } from '../../utils/utils';
+
+export default async function() {
+  await appendToFile('src/main.ts', 'console.log(\'changed\');\n');
+
+  const { message } = await expectToFail(() => ng('update', '--all'));
+  if (!message || !message.includes('Repository is not clean.')) {
+    throw new Error('Expected unclean repository');
+  }
+}