Skip to content

Commit aa786e7

Browse files
devversionclydin
authored andcommitted
build: migrate @angular-devkit/core/node tests to rules_js
Migrates the sub-entry point tests for core/node to `rules_js`.
1 parent a43276e commit aa786e7

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

packages/angular_devkit/architect/node/jobs/job-registry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import { jobs } from '../../src';
109
import { JsonValue, schema } from '@angular-devkit/core';
1110
import { Observable, of } from 'rxjs';
11+
import { jobs } from '../../src';
1212

1313
export class NodeModuleJobRegistry<
1414
MinimumArgumentValueT extends JsonValue = JsonValue,

packages/angular_devkit/architect/node/jobs/job-registry_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88

99
import * as path from 'path';
1010
import { lastValueFrom } from 'rxjs';
11-
import { NodeModuleJobRegistry } from './job-registry';
1211
import { jobs } from '../../src';
12+
import { NodeModuleJobRegistry } from './job-registry';
1313

1414
const root = path.join(__dirname, '../test/jobs');
1515

packages/angular_devkit/core/node/BUILD.bazel

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
# Use of this source code is governed by an MIT-style license that can be
44
# found in the LICENSE file at https://angular.dev/license
55

6-
load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test")
7-
load("//tools:interop.bzl", "ts_project")
6+
load("//tools:defaults2.bzl", "jasmine_test", "ts_project")
87

98
licenses(["notice"])
109

@@ -28,8 +27,6 @@ ts_project(
2827
],
2928
)
3029

31-
# @external_begin
32-
3330
ts_project(
3431
name = "node_test_lib",
3532
testonly = True,
@@ -49,11 +46,7 @@ ts_project(
4946
],
5047
)
5148

52-
jasmine_node_test(
49+
jasmine_test(
5350
name = "node_test",
54-
srcs = [":node_test_lib"],
55-
deps = [
56-
"@npm//chokidar",
57-
],
51+
data = [":node_test_lib_rjs"],
5852
)
59-
# @external_end

0 commit comments

Comments
 (0)