test(@angular-devkit/build-angular): enable dev-server watch tests for vite

These tests can now be enabled.

Author: alan-agius4

packages/angular_devkit/build_angular/src/builders/dev-server/tests/options/watch_spec.ts

@@ -11,116 +11,111 @@ import { executeDevServer } from '../../index';
 import { describeServeBuilder } from '../jasmine-helpers';
 import { BASE_OPTIONS, BUILD_TIMEOUT, DEV_SERVER_BUILDER_INFO } from '../setup';
 
-describeServeBuilder(
-  executeDevServer,
-  DEV_SERVER_BUILDER_INFO,
-  (harness, setupTarget, isViteRun) => {
-    // TODO(fix-vite): currently this is broken in vite.
-    (isViteRun ? xdescribe : describe)('Option: "watch"', () => {
-      beforeEach(() => {
-        setupTarget(harness);
-      });
+describeServeBuilder(executeDevServer, DEV_SERVER_BUILDER_INFO, (harness, setupTarget) => {
+  describe('Option: "watch"', () => {
+    beforeEach(() => {
+      setupTarget(harness);
+    });
 
-      it('does not wait for file changes when false', async () => {
-        harness.useTarget('serve', {
-          ...BASE_OPTIONS,
-          watch: false,
-        });
+    it('does not wait for file changes when false', async () => {
+      harness.useTarget('serve', {
+        ...BASE_OPTIONS,
+        watch: false,
+      });
 
-        await harness
-          .execute()
-          .pipe(
-            timeout(BUILD_TIMEOUT),
-            concatMap(async ({ result }, index) => {
-              expect(result?.success).toBe(true);
+      await harness
+        .execute()
+        .pipe(
+          timeout(BUILD_TIMEOUT),
+          concatMap(async ({ result }, index) => {
+            expect(result?.success).toBe(true);
 
-              switch (index) {
-                case 0:
-                  await harness.modifyFile(
-                    'src/main.ts',
-                    (content) => content + 'console.log("abcd1234");',
-                  );
-                  break;
-                case 1:
-                  fail('Expected files to not be watched.');
-                  break;
-              }
-            }),
-            take(2),
-          )
-          .toPromise()
-          .catch((error) => {
-            // Timeout is expected if watching is disabled
-            if (error instanceof TimeoutError) {
-              return;
+            switch (index) {
+              case 0:
+                await harness.modifyFile(
+                  'src/main.ts',
+                  (content) => content + 'console.log("abcd1234");',
+                );
+                break;
+              case 1:
+                fail('Expected files to not be watched.');
+                break;
             }
-            throw error;
-          });
+          }),
+          take(2),
+        )
+        .toPromise()
+        .catch((error) => {
+          // Timeout is expected if watching is disabled
+          if (error instanceof TimeoutError) {
+            return;
+          }
+          throw error;
+        });
+    });
+
+    it('watches for file changes when not present', async () => {
+      harness.useTarget('serve', {
+        ...BASE_OPTIONS,
+        watch: undefined,
       });
 
-      it('watches for file changes when not present', async () => {
-        harness.useTarget('serve', {
-          ...BASE_OPTIONS,
-          watch: undefined,
-        });
+      const buildCount = await harness
+        .execute()
+        .pipe(
+          timeout(BUILD_TIMEOUT),
+          concatMap(async ({ result }, index) => {
+            expect(result?.success).toBe(true);
 
-        const buildCount = await harness
-          .execute()
-          .pipe(
-            timeout(BUILD_TIMEOUT),
-            concatMap(async ({ result }, index) => {
-              expect(result?.success).toBe(true);
+            switch (index) {
+              case 0:
+                await harness.modifyFile(
+                  'src/main.ts',
+                  (content) => content + 'console.log("abcd1234");',
+                );
+                break;
+              case 1:
+                break;
+            }
+          }),
+          take(2),
+          count(),
+        )
+        .toPromise();
 
-              switch (index) {
-                case 0:
-                  await harness.modifyFile(
-                    'src/main.ts',
-                    (content) => content + 'console.log("abcd1234");',
-                  );
-                  break;
-                case 1:
-                  break;
-              }
-            }),
-            take(2),
-            count(),
-          )
-          .toPromise();
+      expect(buildCount).toBe(2);
+    });
 
-        expect(buildCount).toBe(2);
+    it('watches for file changes when true', async () => {
+      harness.useTarget('serve', {
+        ...BASE_OPTIONS,
+        watch: true,
       });
 
-      it('watches for file changes when true', async () => {
-        harness.useTarget('serve', {
-          ...BASE_OPTIONS,
-          watch: true,
-        });
+      const buildCount = await harness
+        .execute()
+        .pipe(
+          timeout(BUILD_TIMEOUT),
+          concatMap(async ({ result }, index) => {
+            expect(result?.success).toBe(true);
 
-        const buildCount = await harness
-          .execute()
-          .pipe(
-            timeout(BUILD_TIMEOUT),
-            concatMap(async ({ result }, index) => {
-              expect(result?.success).toBe(true);
-
-              switch (index) {
-                case 0:
-                  await harness.modifyFile(
-                    'src/main.ts',
-                    (content) => content + 'console.log("abcd1234");',
-                  );
-                  break;
-                case 1:
-                  break;
-              }
-            }),
-            take(2),
-            count(),
-          )
-          .toPromise();
+            switch (index) {
+              case 0:
+                await harness.modifyFile(
+                  'src/main.ts',
+                  (content) => content + 'console.log("abcd1234");',
+                );
+                break;
+              case 1:
+                break;
+            }
+          }),
+          take(2),
+          count(),
+        )
+        .toPromise();
 
-        expect(buildCount).toBe(2);
-      });
+      expect(buildCount).toBe(2);
     });
-  },
-);
+  });
+});