Skip to content

Commit a80ba19

Browse files
committed
fix(@angular-devkit/build-angular): update terser-webpack-plugin to 3.0.3
Fixes security issue serialize-javascript prior to 3.1.0 allows remote attackers Closes #17912
1 parent 6f5200b commit a80ba19

File tree

3 files changed

+60
-32
lines changed

3 files changed

+60
-32
lines changed

packages/angular_devkit/build_angular/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"stylus-loader": "3.0.2",
5656
"tree-kill": "1.2.2",
5757
"terser": "4.6.3",
58-
"terser-webpack-plugin": "1.4.3",
58+
"terser-webpack-plugin": "3.0.3",
5959
"webpack": "4.39.2",
6060
"webpack-dev-middleware": "3.7.2",
6161
"webpack-dev-server": "3.11.0",

packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -374,13 +374,13 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
374374
(!differentialLoadingNeeded || (differentialLoadingNeeded && fullDifferential)),
375375
};
376376

377+
const globalScriptsNames = globalScriptsByBundleName.map(s => s.bundleName);
377378
extraMinimizers.push(
378379
new TerserPlugin({
379380
sourceMap: scriptsSourceMap,
380381
parallel: true,
381382
cache: true,
382-
chunkFilter: (chunk: compilation.Chunk) =>
383-
!globalScriptsByBundleName.some(s => s.bundleName === chunk.name),
383+
exclude: globalScriptsNames,
384384
terserOptions,
385385
}),
386386
// Script bundles are fully optimized here in one step since they are never downleveled.
@@ -389,8 +389,7 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
389389
sourceMap: scriptsSourceMap,
390390
parallel: true,
391391
cache: true,
392-
chunkFilter: (chunk: compilation.Chunk) =>
393-
globalScriptsByBundleName.some(s => s.bundleName === chunk.name),
392+
include: globalScriptsNames,
394393
terserOptions: {
395394
...terserOptions,
396395
compress: {

yarn.lock

+56-27
Original file line numberDiff line numberDiff line change
@@ -4771,6 +4771,11 @@ fast-deep-equal@^2.0.1:
47714771
resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-2.0.1.tgz#7b05218ddf9667bf7f370bf7fdb2cb15fdd0aa49"
47724772
integrity sha1-ewUhjd+WZ79/Nwv3/bLLFf3Qqkk=
47734773

4774+
fast-deep-equal@^3.1.1:
4775+
version "3.1.3"
4776+
resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-3.1.3.tgz#3a7d56b559d6cbc3eb512325244e619a65c6c525"
4777+
integrity sha512-f3qQ9oQy9j2AhBe/H9VC91wLmKBCCU/gDOnKNAYG5hswO7BLKj09Hc5HYNz9cGI++xlpDCIgDaitVs03ATR84Q==
4778+
47744779
fast-glob@^3.1.1, fast-glob@^3.2.2:
47754780
version "3.2.2"
47764781
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.2.tgz#ade1a9d91148965d4bf7c51f72e1ca662d32e63d"
@@ -5473,6 +5478,11 @@ has-flag@^3.0.0:
54735478
resolved "https://registry.yarnpkg.com/has-flag/-/has-flag-3.0.0.tgz#b5d454dc2199ae225699f3467e5a07f3b955bafd"
54745479
integrity sha1-tdRU3CGZriJWmfNGfloH87lVuv0=
54755480

5481+
has-flag@^4.0.0:
5482+
version "4.0.0"
5483+
resolved "https://registry.yarnpkg.com/has-flag/-/has-flag-4.0.0.tgz#944771fd9c81c81265c4d6941860da06bb59479b"
5484+
integrity sha512-EykJT/Q1KjTWctppgIAgfSO0tKVuZUjhgMr17kqTumMl6Afv3EISleU7qZUzoXDFTAHTDC4NOoG/ZxU3EvlMPQ==
5485+
54765486
has-symbols@^1.0.0:
54775487
version "1.0.0"
54785488
resolved "https://registry.yarnpkg.com/has-symbols/-/has-symbols-1.0.0.tgz#ba1a8f1af2a0fc39650f5c850367704122063b44"
@@ -6457,6 +6467,14 @@ [email protected]:
64576467
merge-stream "^2.0.0"
64586468
supports-color "^6.1.0"
64596469

6470+
jest-worker@^26.0.0:
6471+
version "26.0.0"
6472+
resolved "https://registry.yarnpkg.com/jest-worker/-/jest-worker-26.0.0.tgz#4920c7714f0a96c6412464718d0c58a3df3fb066"
6473+
integrity sha512-pPaYa2+JnwmiZjK9x7p9BoZht+47ecFCDFA/CJxspHzeDvQcfVBLWzCiWyo+EGrSiQMWZtCFo9iSvMZnAAo8vw==
6474+
dependencies:
6475+
merge-stream "^2.0.0"
6476+
supports-color "^7.0.0"
6477+
64606478
jquery@^3.3.1:
64616479
version "3.4.1"
64626480
resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.4.1.tgz#714f1f8d9dde4bdfa55764ba37ef214630d80ef2"
@@ -8277,13 +8295,6 @@ p-map@^2.0.0:
82778295
resolved "https://registry.yarnpkg.com/p-map/-/p-map-2.1.0.tgz#310928feef9c9ecc65b68b17693018a665cea175"
82788296
integrity sha512-y3b8Kpd8OAN444hxfBbFfj1FY/RjtTd8tzYwhUqNYXx0fXx2iX4maP4Qr6qhIKbQXI02wTLAda4fYUbDagTUFw==
82798297

8280-
p-map@^3.0.0:
8281-
version "3.0.0"
8282-
resolved "https://registry.yarnpkg.com/p-map/-/p-map-3.0.0.tgz#d704d9af8a2ba684e2600d9a215983d4141a979d"
8283-
integrity sha512-d3qXVTF/s+W+CdJ5A29wywV2n8CQQYahlgz2bFiA+4eVNJbHJodPZ+/gXwPGh0bOqA+j8S+6+ckmvLGPk1QpxQ==
8284-
dependencies:
8285-
aggregate-error "^3.0.0"
8286-
82878298
p-map@^4.0.0:
82888299
version "4.0.0"
82898300
resolved "https://registry.yarnpkg.com/p-map/-/p-map-4.0.0.tgz#bb2f95a5eda2ec168ec9274e06a747c3e2904d2b"
@@ -9592,13 +9603,20 @@ [email protected], rimraf@^3.0.0:
95929603
dependencies:
95939604
glob "^7.1.3"
95949605

9595-
rimraf@^2.2.8, rimraf@^2.5.2, rimraf@^2.5.4, rimraf@^2.6.0, rimraf@^2.6.1, rimraf@^2.6.2, rimraf@^2.6.3, rimraf@^2.7.1:
9606+
rimraf@^2.2.8, rimraf@^2.5.2, rimraf@^2.5.4, rimraf@^2.6.0, rimraf@^2.6.1, rimraf@^2.6.2, rimraf@^2.6.3:
95969607
version "2.7.1"
95979608
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.7.1.tgz#35797f13a7fdadc566142c29d4f07ccad483e3ec"
95989609
integrity sha512-uWjbaKIK3T1OSVptzX7Nl6PvQ3qAGtKEtVRjRuazjfL3Bx5eI409VZSqgND+4UNnmzLVdPj9FqFJNPqBZFve4w==
95999610
dependencies:
96009611
glob "^7.1.3"
96019612

9613+
rimraf@^3.0.2:
9614+
version "3.0.2"
9615+
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-3.0.2.tgz#f1a5402ba6220ad52cc1282bac1ae3aa49fd061a"
9616+
integrity sha512-JZkJMZkAGFFPP2YqXZXPbMlMBgsxzE8ILs4lMIX/2o0L9UBw9O/Y3o6wFw/i9YLapcUJWwqbi3kdxIPdC62TIA==
9617+
dependencies:
9618+
glob "^7.1.3"
9619+
96029620
rimraf@~2.4.0:
96039621
version "2.4.5"
96049622
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.4.5.tgz#ee710ce5d93a8fdb856fb5ea8ff0e2d75934b2da"
@@ -9828,7 +9846,7 @@ schema-utils@^2.6.1:
98289846
ajv "^6.10.2"
98299847
ajv-keywords "^3.4.1"
98309848

9831-
schema-utils@^2.7.0:
9849+
schema-utils@^2.6.6, schema-utils@^2.7.0:
98329850
version "2.7.0"
98339851
resolved "https://registry.yarnpkg.com/schema-utils/-/schema-utils-2.7.0.tgz#17151f76d8eae67fbbf77960c33c676ad9f4efc7"
98349852
integrity sha512-0ilKFI6QQF5nxDZLFn2dMjvc4hjg/Wkg7rHd3jK6/A4a1Hl9VFdQWvgB1UMGoU94pad1P/8N7fMcEnLnSiju8A==
@@ -9968,11 +9986,6 @@ serialize-javascript@^1.7.0:
99689986
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-1.9.1.tgz#cfc200aef77b600c47da9bb8149c943e798c2fdb"
99699987
integrity sha512-0Vb/54WJ6k5v8sSWN09S0ora+Hnr+cX40r9F170nT+mSkaxltoE/7R3OrIdBSUv1OoiobH1QoWQbCnAO+e8J1A==
99709988

9971-
serialize-javascript@^2.1.2:
9972-
version "2.1.2"
9973-
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-2.1.2.tgz#ecec53b0e0317bdc95ef76ab7074b7384785fa61"
9974-
integrity sha512-rs9OggEUF0V4jUSecXazOYsLfu7OGK2qIn3c7IPBiffz32XniEp/TX9Xmc9LQfK2nQ2QKHvZ2oygKUGU0lG4jQ==
9975-
99769989
serialize-javascript@^3.1.0:
99779990
version "3.1.0"
99789991
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-3.1.0.tgz#8bf3a9170712664ef2561b44b691eafe399214ea"
@@ -10813,6 +10826,13 @@ supports-color@^6.1.0:
1081310826
dependencies:
1081410827
has-flag "^3.0.0"
1081510828

10829+
supports-color@^7.0.0:
10830+
version "7.1.0"
10831+
resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-7.1.0.tgz#68e32591df73e25ad1c4b49108a2ec507962bfd1"
10832+
integrity sha512-oRSIpR8pxT1Wr2FquTNnGet79b3BWljqOuoW/h4oBhxJ/HUbX5nX6JSruTkvXDCFMwDPvsaTTbvMLKZWSy0R5g==
10833+
dependencies:
10834+
has-flag "^4.0.0"
10835+
1081610836
1081710837
version "1.2.0"
1081810838
resolved "https://registry.yarnpkg.com/symbol-observable/-/symbol-observable-1.2.0.tgz#c22688aed4eab3cdc2dfeacbb561660560a00804"
@@ -10841,7 +10861,7 @@ tar@^4, tar@^4.4.10, tar@^4.4.4, tar@^4.4.8:
1084110861
safe-buffer "^5.1.2"
1084210862
yallist "^3.0.3"
1084310863

10844-
tar@^6.0.1:
10864+
tar@^6.0.2:
1084510865
version "6.0.2"
1084610866
resolved "https://registry.yarnpkg.com/tar/-/tar-6.0.2.tgz#5df17813468a6264ff14f766886c622b84ae2f39"
1084710867
integrity sha512-Glo3jkRtPcvpDlAs/0+hozav78yoXKFr+c4wgw62NNMO3oo4AaJdCo21Uu7lcwr55h39W2XD1LMERc64wtbItg==
@@ -10867,20 +10887,20 @@ term-size@^1.2.0:
1086710887
dependencies:
1086810888
execa "^0.7.0"
1086910889

10870-
terser-webpack-plugin@1.4.3:
10871-
version "1.4.3"
10872-
resolved "https://registry.yarnpkg.com/terser-webpack-plugin/-/terser-webpack-plugin-1.4.3.tgz#5ecaf2dbdc5fb99745fd06791f46fc9ddb1c9a7c"
10873-
integrity sha512-QMxecFz/gHQwteWwSo5nTc6UaICqN1bMedC5sMtUc7y3Ha3Q8y6ZO0iCR8pq4RJC8Hjf0FEPEHZqcMB/+DFCrA==
10890+
terser-webpack-plugin@3.0.3:
10891+
version "3.0.3"
10892+
resolved "https://registry.yarnpkg.com/terser-webpack-plugin/-/terser-webpack-plugin-3.0.3.tgz#23bda2687b197f878a743373b9411d917adc2e45"
10893+
integrity sha512-bZFnotuIKq5Rqzrs+qIwFzGdKdffV9epG5vDSEbYzvKAhPeR5RbbrQysfPgbIIMhNAQtZD2hGwBfSKUXjXZZZw==
1087410894
dependencies:
10875-
cacache "^12.0.2"
10876-
find-cache-dir "^2.1.0"
10877-
is-wsl "^1.1.0"
10878-
schema-utils "^1.0.0"
10879-
serialize-javascript "^2.1.2"
10895+
cacache "^15.0.4"
10896+
find-cache-dir "^3.3.1"
10897+
jest-worker "^26.0.0"
10898+
p-limit "^2.3.0"
10899+
schema-utils "^2.6.6"
10900+
serialize-javascript "^3.1.0"
1088010901
source-map "^0.6.1"
10881-
terser "^4.1.2"
10882-
webpack-sources "^1.4.0"
10883-
worker-farm "^1.7.0"
10902+
terser "^4.6.13"
10903+
webpack-sources "^1.4.3"
1088410904

1088510905
terser-webpack-plugin@^1.4.1:
1088610906
version "1.4.1"
@@ -10915,6 +10935,15 @@ terser@^4.1.2:
1091510935
source-map "~0.6.1"
1091610936
source-map-support "~0.5.12"
1091710937

10938+
terser@^4.6.13:
10939+
version "4.7.0"
10940+
resolved "https://registry.yarnpkg.com/terser/-/terser-4.7.0.tgz#15852cf1a08e3256a80428e865a2fa893ffba006"
10941+
integrity sha512-Lfb0RiZcjRDXCC3OSHJpEkxJ9Qeqs6mp2v4jf2MHfy8vGERmVDuvjXdd/EnP5Deme5F2yBRBymKmKHCBg2echw==
10942+
dependencies:
10943+
commander "^2.20.0"
10944+
source-map "~0.6.1"
10945+
source-map-support "~0.5.12"
10946+
1091810947
test-exclude@^5.2.2:
1091910948
version "5.2.3"
1092010949
resolved "https://registry.yarnpkg.com/test-exclude/-/test-exclude-5.2.3.tgz#c3d3e1e311eb7ee405e092dac10aefd09091eac0"

0 commit comments

Comments
 (0)