fix(scripts): allow using same lib inside app (#3814)

Fix #2141

Author: filipesilva

packages/angular-cli/models/webpack-build-common.ts

@@ -59,16 +59,11 @@ export function getWebpackCommonConfig(
   if (appConfig.scripts.length > 0) {
     const globalScripts = extraEntryParser(appConfig.scripts, appRoot, 'scripts');
 
-    // add script entry points
-    globalScripts.forEach(script =>
-      entryPoints[script.entry]
-        ? entryPoints[script.entry].push(script.path)
-        : entryPoints[script.entry] = [script.path]
-    );
-
-    // load global scripts using script-loader
-    extraRules.push({
-      include: globalScripts.map((script) => script.path), test: /\.js$/, loader: 'script-loader'
+    // add entry points and lazy chunks
+    globalScripts.forEach(script => {
+      let scriptPath = `script-loader!${script.path}`;
+      if (script.lazy) { lazyChunks.push(script.entry); }
+      entryPoints[script.entry] = (entryPoints[script.entry] || []).concat(scriptPath);
     });
   }
 

tests/e2e/tests/build/scripts-array.ts

@@ -1,6 +1,7 @@
 import {
   writeMultipleFiles,
-  expectFileToMatch
+  expectFileToMatch,
+  appendToFile
 } from '../../utils/fs';
 import { ng } from '../../utils/process';
 import { updateJsonFile } from '../../utils/project';
@@ -16,6 +17,7 @@ export default function () {
     'src/common-entry-script.js': 'console.log(\'common-entry-script\');',
     'src/common-entry-style.css': '.common-entry-style { color: red }',
   })
+    .then(() => appendToFile('src/main.ts', 'import \'./string-script.js\';'))
     .then(() => updateJsonFile('angular-cli.json', configJson => {
       const app = configJson['apps'][0];
       app['scripts'] = [
@@ -48,5 +50,7 @@ export default function () {
       <script type="text/javascript" src="scripts.bundle.js"></script>
       <script type="text/javascript" src="vendor.bundle.js"></script>
       <script type="text/javascript" src="main.bundle.js"></script>
-    `));
+    `))
+     // ensure scripts aren't using script-loader when imported from the app
+    .then(() => expectFileToMatch('dist/main.bundle.js', 'console.log(\'string-script\');'));
 }