ci: move Windows CI job to GHA

The Windows E2E tests are now executed with a Github Action job via an additional entry in the existing E2E job's matrix.
The CircleCI configuration previously needed to execute the job with CircleCI has also been removed.

Author: clydin

.bazelrc

@@ -150,6 +150,12 @@ build:remote --host_cpu=k8
 # Set up authentication mechanism for RBE
 build:remote --google_default_credentials
 
+# Use HTTP remote cache
+build:remote-cache --remote_cache=https://storage.googleapis.com/angular-team-cache
+build:remote-cache --remote_accept_cached=true
+build:remote-cache --remote_upload_local_results=true
+build:remote-cache --google_default_credentials
+
 ###############################
 # NodeJS rules settings
 # These settings are required for rules_nodejs

.circleci/bazel.windows.rc

@@ -10,7 +10,6 @@
 version: 2.1
 
 orbs:
-  browser-tools: circleci/[email protected]
   devinfra: angular/[email protected]
 
 parameters:
@@ -24,7 +23,6 @@ parameters:
 # Windows needs its own cache key because binaries in node_modules are different.
 # See https://circleci.com/docs/2.0/caching/#restoring-cache for how prefixes work in CircleCI.
 var_1: &cache_key v1-angular_devkit-16.14-{{ checksum "yarn.lock" }}
-var_1_win: &cache_key_win v1-angular_devkit-win-16.14-{{ checksum "yarn.lock" }}
 var_3: &default_nodeversion '18.13'
 var_3_major: &default_nodeversion_major '18'
 # The major version of node toolchains. See tools/toolchain_info.bzl
@@ -89,16 +87,6 @@ executors:
     working_directory: ~/ng
     resource_class: xlarge
 
-  windows-executor:
-    # Same as https://circleci.com/orbs/registry/orb/circleci/windows, but named.
-    working_directory: ~/ng
-    resource_class: windows.large
-    shell: powershell.exe -ExecutionPolicy Bypass
-    machine:
-      # Contents of this image:
-      # https://circleci.com/developer/machine/image/windows-server-2022-gui
-      image: 'windows-server-2022-gui:current'
-
 # Command Definitions
 # https://circleci.com/docs/2.0/reusing-config/#authoring-reusable-commands
 commands:
@@ -123,30 +111,12 @@ commands:
           base_revision: << pipeline.git.base_revision >>
           head_revision: << pipeline.git.revision >>
 
-  rebase_pr_win:
-    steps:
-      - devinfra/rebase-pr-on-target-branch:
-          base_revision: << pipeline.git.base_revision >>
-          head_revision: << pipeline.git.revision >>
-          # Use `bash.exe` as Shell because the CircleCI-orb command is an
-          # included Bash script and expects Bash as shell.
-          shell: bash.exe
-
   custom_attach_workspace:
     description: Attach workspace at a predefined location
     steps:
       - attach_workspace:
           at: *workspace_location
 
-  setup_windows:
-    steps:
-      - initialize_env
-      - run: nvm install 18.13.0
-      - run: nvm use 18.13.0
-      - run: npm install -g [email protected] @bazel/bazelisk@${BAZELISK_VERSION}
-      - run: node --version
-      - run: yarn --version
-
   setup_bazel_rbe:
     parameters:
       key:
@@ -265,50 +235,6 @@ jobs:
           command: yarn admin snapshots --verbose
       - fail_fast
 
-  # Windows jobs
-  e2e-cli-win:
-    executor: windows-executor
-    parallelism: 12
-    steps:
-      - checkout
-      - setup_windows
-      - rebase_pr_win
-      - setup_bazel_rbe
-      - restore_cache:
-          keys:
-            - *cache_key_win
-      - run:
-          # We use Arsenal Image Mounter (AIM) instead of ImDisk because of: https://github.com/nodejs/node/issues/6861
-          # Useful resources for AIM: http://reboot.pro/index.php?showtopic=22068
-          name: 'Arsenal Image Mounter (RAM Disk)'
-          command: |
-            pwsh ./.circleci/win-ram-disk.ps1
-      - run: yarn install --frozen-lockfile --cache-folder ~/.cache/yarn
-      - save_cache:
-          key: *cache_key_win
-          paths:
-            - ~/.cache/yarn
-            # Path where Arsenal Image Mounter files are downloaded.
-            # Must match path in .circleci/win-ram-disk.ps1
-            - ./aim
-      - run:
-          name: Execute E2E Tests
-          environment:
-            # Required by `yarn ng-dev`
-            # See https://github.com/angular/angular/issues/46858
-            PWD: .
-          command: |
-            mkdir X:/ramdisk/e2e
-            bazel test --define=E2E_TEMP=X:/ramdisk/e2e --define=E2E_SHARD_TOTAL=$env:CIRCLE_NODE_TOTAL --define=E2E_SHARD_INDEX=$env:CIRCLE_NODE_INDEX --config=e2e //tests/legacy-cli:e2e.npm_node18
-          # This timeout provides time for the actual tests to timeout and report status
-          # instead of CircleCI stopping the job without test failure information.
-          no_output_timeout: 40m
-      - fail_fast
-      - store_artifacts:
-          path: dist/testlogs/tests/legacy-cli/e2e.npm_node18
-      - store_test_results:
-          path: dist/testlogs/tests/legacy-cli/e2e.npm_node18
-
 workflows:
   version: 2
   default_workflow:
@@ -346,13 +272,8 @@ workflows:
           requires:
             - build
 
-      # Windows jobs
-      - e2e-cli-win:
-          <<: *only_release_branches
-
       # Publish jobs
       - snapshot_publish:
           <<: *only_builds_branches
           requires:
-            - setup
-            - e2e-cli-win
+            - build

.circleci/dynamic_config.yml

@@ -104,13 +104,18 @@ jobs:
   e2e:
     strategy:
       matrix:
-        os: [ubuntu-latest]
+        os: [ubuntu-latest, windows-latest]
         node: [18]
         subset: [npm, yarn, esbuild]
-        shard: [0, 1, 2, 3]
+        shard: [0, 1, 2, 3, 4, 5]
         exclude:
           # Exclude Node.js v16 when running on a PR
           - node: ${{ github.event_name != 'pull_request' && 'none' || '16' }}
+          # Exclude Windows when running on a PR
+          - os: ${{ github.event_name != 'pull_request' && 'none' || 'windows-latest' }}
+          # Skip yarn subset for Windows
+          - os: windows-latest
+            subset: yarn
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
@@ -124,4 +129,4 @@ jobs:
       - name: Setup Bazel RBE
         uses: angular/dev-infra/github-actions/bazel/configure-remote@ad327ca5766ef5dbf071a37056cee034bee258cd
       - name: Run CLI E2E tests
-        run: yarn bazel test --define=E2E_SHARD_TOTAL=4 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
+        run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}