Skip to content

Commit 9d53550

Browse files
committed
fixup! test: use random ports for local verdaccio npm servers
1 parent c02fdca commit 9d53550

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/legacy-cli/e2e_runner.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import * as path from 'path';
99
import { setGlobalVariable } from './e2e/utils/env';
1010
import { gitClean } from './e2e/utils/git';
1111
import { createNpmRegistry } from './e2e/utils/registry';
12-
import { AddressInfo, createServer } from 'net';
12+
import { AddressInfo, createServer, Server } from 'net';
1313

1414
Error.stackTraceLimit = Infinity;
1515

@@ -264,8 +264,11 @@ function printFooter(testName: string, startTime: number) {
264264
function findFreePort() {
265265
return new Promise<number>((resolve, reject) => {
266266
const srv = createServer();
267-
srv.once('listening', () => resolve((srv.address() as AddressInfo).port));
268-
srv.once('error', reject);
267+
srv.once('listening', () => {
268+
const port = (srv.address() as AddressInfo).port;
269+
srv.close((e) => (e ? reject(e) : resolve(port)));
270+
});
271+
srv.once('error', (e) => srv.close(() => reject(e)));
269272
srv.listen();
270273
});
271274
}

0 commit comments

Comments
 (0)