Skip to content

Commit 9cf4e37

Browse files
committed
fixup! test: run legacy-cli e2e tests via bazel
fixup: add ChromeHeadlessNoSandbox browser to to karma builder
1 parent 46561d8 commit 9cf4e37

File tree

2 files changed

+6
-27
lines changed
  • packages/angular_devkit/build_angular/src/builders/karma
  • tests/legacy-cli/e2e/utils

2 files changed

+6
-27
lines changed

packages/angular_devkit/build_angular/src/builders/karma/index.ts

+6
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,12 @@ function getBuiltInKarmaConfig(
222222
logLevel: karma.constants.LOG_INFO,
223223
autoWatch: true,
224224
browsers: ['Chrome'],
225+
customLaunchers: {
226+
ChromeHeadlessNoSandbox: {
227+
base: 'ChromeHeadless',
228+
flags: ['--no-sandbox', '--headless', '--disable-gpu', '--disable-dev-shm-usage'],
229+
},
230+
},
225231
restartOnFileChange: true,
226232
};
227233
}

tests/legacy-cli/e2e/utils/project.ts

-27
Original file line numberDiff line numberDiff line change
@@ -245,38 +245,11 @@ export async function useCIChrome(projectName: string, projectDir = ''): Promise
245245
);
246246
}
247247

248-
const karmaConf = path.join(projectDir, 'karma.conf.js');
249-
250-
// Create one with default config if it doesn't exist
251-
if (!fs.existsSync(karmaConf)) {
252-
await writeFile(karmaConf, KARMA_CONF_DEFAULT.replace('$PROJECT_NAME$', projectName));
253-
}
254-
255248
// Update to use the headless sandboxed chrome
256-
await replaceInFile(
257-
karmaConf,
258-
/browsers:.*\]\s*,/,
259-
`
260-
browsers: ['ChromeHeadlessNoSandbox'],
261-
customLaunchers: {
262-
ChromeHeadlessNoSandbox: {
263-
base: 'ChromeHeadless',
264-
flags: [
265-
'--no-sandbox',
266-
'--headless',
267-
'--disable-gpu',
268-
'--disable-dev-shm-usage',
269-
],
270-
}
271-
},
272-
`,
273-
);
274-
275249
return updateJsonFile('angular.json', (workspaceJson) => {
276250
const project = workspaceJson.projects[projectName];
277251
const appTargets = project.targets || project.architect;
278252
appTargets.test.options.browsers = 'ChromeHeadlessNoSandbox';
279-
appTargets.test.options.karmaConfig = karmaConf;
280253
});
281254
}
282255

0 commit comments

Comments
 (0)