Skip to content

Commit 8edb612

Browse files
clydinhansl
authored andcommitted
refactor(@angular/cli): remove unused ui spinner (#4310)
1 parent aa87de7 commit 8edb612

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@
7878
"node-sass": "^4.3.0",
7979
"nopt": "^3.0.1",
8080
"opn": "4.0.1",
81-
"ora": "^0.2.0",
8281
"portfinder": "1.0.9",
8382
"postcss-loader": "^0.9.1",
8483
"raw-loader": "^0.5.1",
@@ -97,7 +96,6 @@
9796
"stylus": "^0.54.5",
9897
"stylus-loader": "^2.4.0",
9998
"temp": "0.8.3",
100-
"through": "^2.3.6",
10199
"typescript": "~2.0.3",
102100
"url-loader": "^0.5.7",
103101
"walk-sync": "^0.2.6",
@@ -147,6 +145,7 @@
147145
"resolve-bin": "^0.4.0",
148146
"rewire": "^2.5.1",
149147
"sinon": "^1.17.3",
148+
"through": "^2.3.6",
150149
"tree-kill": "^1.0.0",
151150
"ts-node": "^1.3.0",
152151
"tslint": "^4.0.2"

packages/@angular/cli/ember-cli/lib/ui/index.js

+3-23
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
var ora = require('ora');
43
var Promise = require('../ext/promise');
54
var EOL = require('os').EOL;
65
var chalk = require('chalk');
@@ -32,20 +31,8 @@ module.exports = UI;
3231
**/
3332

3433
function UI(options) {
35-
var spinner = this.spinner = ora({ color: 'green' });
36-
37-
this.through = require('through');
38-
3934
// Output stream
40-
this.actualOutputStream = options.outputStream;
41-
this.outputStream = this.through(function(data) {
42-
spinner.stop();
43-
this.emit('data', data);
44-
});
45-
46-
this.outputStream.setMaxListeners(0);
47-
this.outputStream.pipe(this.actualOutputStream);
48-
35+
this.outputStream = options.outputStream;
4936
this.inputStream = options.inputStream;
5037
this.errorStream = options.errorStream;
5138

@@ -174,19 +161,12 @@ UI.prototype.setWriteLevel = function(level) {
174161

175162
UI.prototype.startProgress = function(message/*, stepString*/) {
176163
if (this.writeLevelVisible('INFO')) {
177-
if (this.ci) {
178-
this.writeLine(message);
179-
} else {
180-
this.spinner.text = message;
181-
this.spinner.start();
182-
}
164+
this.writeLine(message);
183165
}
184166
};
185167

186168
UI.prototype.stopProgress = function() {
187-
if (this.writeLevelVisible('INFO') && !this.ci) {
188-
this.spinner.stop();
189-
}
169+
190170
};
191171

192172
UI.prototype.prompt = function(questions, callback) {

packages/@angular/cli/package.json

-2
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
"node-sass": "^4.3.0",
6161
"nopt": "^3.0.1",
6262
"opn": "4.0.1",
63-
"ora": "^0.2.0",
6463
"portfinder": "1.0.9",
6564
"postcss-loader": "^0.9.1",
6665
"raw-loader": "^0.5.1",
@@ -78,7 +77,6 @@
7877
"stylus": "^0.54.5",
7978
"stylus-loader": "^2.4.0",
8079
"temp": "0.8.3",
81-
"through": "^2.3.6",
8280
"typescript": "~2.0.3",
8381
"url-loader": "^0.5.7",
8482
"walk-sync": "^0.2.6",

0 commit comments

Comments
 (0)