fix(build): don't leave dist folder on fail (#4047)

Author: filipesilva

package.json

@@ -137,7 +137,7 @@
     "@types/rimraf": "0.0.25-alpha",
     "@types/semver": "^5.3.30",
     "@types/source-map": "^0.5.0",
-    "@types/webpack": "2.2.0",
+    "@types/webpack": "^2.2.1",
     "chai": "^3.5.0",
     "conventional-changelog": "^1.1.0",
     "dtsgenerator": "^0.7.1",

packages/angular-cli/models/webpack-configs/common.ts

@@ -133,6 +133,7 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
       ].concat(extraRules)
     },
     plugins: [
+      new webpack.NoEmitOnErrorsPlugin(),
       new HtmlWebpackPlugin({
         template: path.resolve(appRoot, appConfig.index),
         filename: path.resolve(buildOptions.outputPath, appConfig.index),

tests/e2e/tests/build/fail-build.ts

@@ -1,9 +1,11 @@
 import {ng} from '../../utils/process';
 import {expectToFail} from '../../utils/utils';
-import {deleteFile} from '../../utils/fs';
+import {deleteFile, expectFileToExist} from '../../utils/fs';
 
 export default function() {
   return deleteFile('src/app/app.component.ts')
     // This is supposed to fail since there's a missing file
-    .then(() => expectToFail(() => ng('build')));
+    .then(() => expectToFail(() => ng('build')))
+    // Failed builds don't leave behind dist/
+    .then(() => expectToFail(() => expectFileToExist('dist/')));
 }