Skip to content

Commit 77f21c1

Browse files
committed
build: update @types/node to 16.11.7
Node.js 14 is no longer supported.
1 parent 78547f6 commit 77f21c1

File tree

10 files changed

+14
-18
lines changed

10 files changed

+14
-18
lines changed

goldens/public-api/angular_devkit/schematics/index.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
55
```ts
66

7-
/// <reference types="node" />
8-
97
import { BaseException } from '@angular-devkit/core';
108
import { JsonValue } from '@angular-devkit/core';
119
import { logging } from '@angular-devkit/core';

goldens/public-api/angular_devkit/schematics/testing/index.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
55
```ts
66

7-
/// <reference types="node" />
8-
97
import { JsonValue } from '@angular-devkit/core';
108
import { logging } from '@angular-devkit/core';
119
import { Observable } from 'rxjs';

goldens/public-api/angular_devkit/schematics/tools/index.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
55
```ts
66

7-
/// <reference types="node" />
8-
97
import { BaseException } from '@angular-devkit/core';
108
import { JsonObject } from '@angular-devkit/core';
119
import { JsonValue } from '@angular-devkit/core';

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
"@types/karma": "^6.3.0",
109109
"@types/less": "^3.0.3",
110110
"@types/loader-utils": "^2.0.0",
111-
"@types/node": "^14.15.0",
111+
"@types/node": "^16.11.7",
112112
"@types/node-fetch": "^2.1.6",
113113
"@types/npm-package-arg": "^6.1.0",
114114
"@types/pacote": "^11.1.3",

packages/angular_devkit/benchmark/src/monitored-process.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,13 @@ export class LocalMonitoredProcess implements MonitoredProcess {
5959
map((statsByProcess) => {
6060
// Ignore the spawned shell in the total process number.
6161
const pids = Object.keys(statsByProcess).filter(
62-
(pid) => pid != childProcess.pid.toString(),
62+
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
63+
(pid) => pid != childProcess.pid!.toString(),
6364
);
6465
const processes = pids.length;
6566
// We want most stats from the parent process.
66-
const { pid, ppid, ctime, elapsed, timestamp } = statsByProcess[childProcess.pid];
67+
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
68+
const { pid, ppid, ctime, elapsed, timestamp } = statsByProcess[childProcess.pid!];
6769

6870
// CPU and memory should be agreggated.
6971
let cpu = 0;

packages/angular_devkit/schematics_cli/blank/project-files/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"typescript": "~5.0.2"
1919
},
2020
"devDependencies": {
21-
"@types/node": "^14.15.0",
21+
"@types/node": "^16.11.7",
2222
"@types/jasmine": "~4.3.0",
2323
"jasmine": "^4.0.0"
2424
}

packages/angular_devkit/schematics_cli/schematic/files/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"typescript": "~5.0.2"
1919
},
2020
"devDependencies": {
21-
"@types/node": "^14.15.0",
21+
"@types/node": "^16.11.7",
2222
"@types/jasmine": "~4.3.0",
2323
"jasmine": "~4.6.0"
2424
}

packages/schematics/angular/utility/latest-versions/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"dependencies": {
66
"@types/jasmine": "~4.3.0",
7-
"@types/node": "^14.15.0",
7+
"@types/node": "^16.11.7",
88
"jasmine-core": "~4.6.0",
99
"jasmine-spec-reporter": "~7.0.0",
1010
"karma-chrome-launcher": "~3.2.0",

tests/legacy-cli/e2e/utils/process.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,13 +236,13 @@ export async function killAllProcesses(signal = 'SIGTERM'): Promise<void> {
236236

237237
while (_processes.length) {
238238
const childProc = _processes.pop();
239-
if (!childProc) {
239+
if (!childProc || childProc.pid === undefined) {
240240
continue;
241241
}
242242

243243
processesToKill.push(
244244
new Promise<void>((resolve) => {
245-
treeKill(childProc.pid, signal, () => {
245+
treeKill(childProc.pid!, signal, () => {
246246
// Ignore all errors.
247247
// This is due to a race condition with the `waitForMatch` logic.
248248
// where promises are resolved on matches and not when the process terminates.

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3289,10 +3289,10 @@
32893289
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.17.60.tgz#35f3d6213daed95da7f0f73e75bcc6980e90597b"
32903290
integrity sha512-F0KIgDJfy2nA3zMLmWGKxcH2ZVEtCZXHHdOQs2gSaQ27+lNeEfGxzkIw90aXswATX7AZ33tahPbzy6KAfUreVw==
32913291

3292-
"@types/node@^14.15.0":
3293-
version "14.18.44"
3294-
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.44.tgz#1d42ba325c5b434ee78437378ef0b7589f32c151"
3295-
integrity sha512-Sg79dXC3jrRlG0QOLrK5eq2hRzpU4pkD7xBiYNYJ6r9OitJMxkpTpWf6m3qa2AWzb76uMHx+6x5T1Y/WAiS3nw==
3292+
"@types/node@^16.11.7":
3293+
version "16.18.31"
3294+
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.31.tgz#7de39c2b9363f0d95b129cc969fcbf98e870251c"
3295+
integrity sha512-KPXltf4z4g517OlVJO9XQ2357CYw7fvuJ3ZuBynjXC5Jos9i+K7LvFb7bUIwtJXSZj0vTp9Q6NJBSQpkwwO8Zw==
32963296

32973297
"@types/npm-package-arg@*", "@types/npm-package-arg@^6.1.0":
32983298
version "6.1.1"

0 commit comments

Comments
 (0)