Skip to content

Commit 6d93ef6

Browse files
webmaxruhansl
authored andcommitted
fix(@schematics/angular): Make manifest.json correct and consistent
Closes #776
1 parent aa675f1 commit 6d93ef6

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

packages/angular/pwa/pwa/files/assets/manifest.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"short_name": "<%= title %>",
44
"theme_color": "#1976d2",
55
"background_color": "#fafafa",
6-
"display": "browser",
6+
"display": "standalone",
77
"scope": "/",
88
"start_url": "/",
99
"icons": [
@@ -47,6 +47,5 @@
4747
"sizes": "512x512",
4848
"type": "image/png"
4949
}
50-
],
51-
"splash_pages": null
50+
]
5251
}

packages/schematics/angular/service-worker/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,7 @@ function updateIndexFile(options: ServiceWorkerOptions): Rule {
190190
const indent = getIndent(closingHeadTagLine) + ' ';
191191
const itemsToAdd = [
192192
'<link rel="manifest" href="assets/manifest.json">',
193-
'<meta name="Description" content="Angular Application">',
194-
'<meta name="theme-color" content="#FFFFFF">',
193+
'<meta name="theme-color" content="#1976d2">',
195194
];
196195

197196
const textToInsert = itemsToAdd

packages/schematics/angular/service-worker/index_spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ describe('Service Worker Schematic', () => {
102102
const content = tree.readContent('projects/bar/src/index.html');
103103

104104
expect(content).toMatch(/<link rel="manifest" href="assets\/manifest.json">/);
105-
expect(content).toMatch(/<meta name="Description" content="Angular Application">/);
106-
expect(content).toMatch(/<meta name="theme-color" content="#FFFFFF">/);
105+
expect(content).toMatch(/<meta name="theme-color" content="#1976d2">/);
107106
});
108107
});

0 commit comments

Comments
 (0)