feat(@schematics/angular): remove annotateForClosureCompiler in libraries tsconfig (#13546)

alan-agius4 · hansl · commit 6ae1752891d5 · 2019-01-30T11:24:04.000-08:00
Users outside of Google don't usually need closure annotations.

We should also follow up with ng-packagr to remove tsickle from peerDependency and afterwards, we be able to remove tsickle from the added dependencies when running this schematic
diff --git a/packages/schematics/angular/library/files/__projectRoot__/tsconfig.lib.json.template b/packages/schematics/angular/library/files/__projectRoot__/tsconfig.lib.json.template
@@ -18,7 +18,6 @@
     ]
   },
   "angularCompilerOptions": {
-    "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
diff --git a/tests/angular_devkit/build_ng_packagr/ng-packaged/projects/lib/tsconfig.lib.json b/tests/angular_devkit/build_ng_packagr/ng-packaged/projects/lib/tsconfig.lib.json
@@ -16,7 +16,6 @@
     ]
   },
   "angularCompilerOptions": {
-    "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`]`
`19`	`19`	`},`
`20`	`20`	`"angularCompilerOptions": {`
`21`		`- "annotateForClosureCompiler": true,`
`22`	`21`	`"skipTemplateCodegen": true,`
`23`	`22`	`"strictMetadataEmit": true,`
`24`	`23`	`"fullTemplateTypeCheck": true,`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`	`]`
`17`	`17`	`},`
`18`	`18`	`"angularCompilerOptions": {`
`19`		`- "annotateForClosureCompiler": true,`
`20`	`19`	`"skipTemplateCodegen": true,`
`21`	`20`	`"strictMetadataEmit": true,`
`22`	`21`	`"fullTemplateTypeCheck": true,`