fix(@angular-devkit/schematics): Fix deep copy logic

Author: Brocco

packages/angular_devkit/core/src/utils/object.ts

@@ -14,3 +14,24 @@ export function mapObject<T, V>(obj: {[k: string]: T},
     return acc;
   }, {});
 }
+
+// tslint:disable-next-line:no-any
+export function deepCopy<T extends any> (object: T): T {
+  if (Array.isArray(object)) {
+    // tslint:disable-next-line:no-any
+    return object.map((o: any) => deepCopy(o));
+  } else if (typeof object === 'object') {
+    if (object['toJSON']) {
+      return JSON.parse((object['toJSON'] as () => string)());
+    }
+
+    const copy = {} as T;
+    for (const key of Object.keys(object)) {
+      copy[key] = deepCopy(object[key]);
+    }
+
+    return copy;
+  } else {
+    return object;
+  }
+}

packages/angular_devkit/schematics/tools/schema-option-transform.ts

@@ -7,6 +7,7 @@
  */
 import {
   BaseException,
+  deepCopy,
   schema,
 } from '@angular-devkit/core';
 import { Observable, of as observableOf } from 'rxjs';
@@ -26,29 +27,11 @@ export class InvalidInputOptions extends BaseException {
   }
 }
 
-
-// tslint:disable-next-line:no-any
-function _deepCopy<T extends {[key: string]: any}>(object: T): T {
-  return JSON.parse(JSON.stringify(object));
-  // const copy = {} as T;
-  // for (const key of Object.keys(object)) {
-  //   if (typeof object[key] == 'object') {
-  //     copy[key] = _deepCopy(object[key]);
-  //     break;
-  //   } else {
-  //       copy[key] = object[key];
-  //   }
-  // }
-
-  // return copy;
-}
-
-
 // This can only be used in NodeJS.
 export function validateOptionsWithSchema(registry: schema.SchemaRegistry) {
   return <T extends {}>(schematic: SchematicDesc, options: T): Observable<T> => {
     // Prevent a schematic from changing the options object by making a copy of it.
-    options = _deepCopy(options);
+    options = deepCopy(options);
 
     if (schematic.schema && schematic.schemaJson) {
       // Make a deep copy of options.