Skip to content

Commit 5f4c87a

Browse files
Charles Lydingfilipesilva
Charles Lyding
authored andcommitted
refactor(@angular/cli): remove unnecessary use of ember-cli promise wrapper
1 parent 174014c commit 5f4c87a

File tree

4 files changed

+9
-16
lines changed

4 files changed

+9
-16
lines changed

packages/@angular/cli/lib/ast-tools/change.spec.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
1-
'use strict';
2-
31
// This needs to be first so fs module can be mocked correctly.
4-
let mockFs = require('mock-fs');
5-
6-
import {it} from './spec-utils';
7-
import {InsertChange, NodeHost, RemoveChange, ReplaceChange} from './change';
8-
import fs = require('fs');
2+
import mockFs = require('mock-fs');
93

10-
let path = require('path');
11-
let Promise = require('@angular/cli/ember-cli/lib/ext/promise');
4+
import { it } from './spec-utils';
5+
import { InsertChange, NodeHost, RemoveChange, ReplaceChange } from './change';
6+
import { readFile } from 'fs-extra';
7+
import * as path from 'path';
128

13-
const readFile = Promise.denodeify(fs.readFile);
149

1510
describe('Change', () => {
1611
let sourcePath = 'src/app/my-component';

packages/@angular/cli/tasks/git-init.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { oneLine } from 'common-tags';
2+
import denodeify = require('denodeify');
23

3-
const Promise = require('../ember-cli/lib/ext/promise');
4-
const exec = Promise.denodeify(require('child_process').exec);
4+
const exec: any = denodeify(require('child_process').exec);
55
const path = require('path');
66
const pkg = require('../package.json');
77
const fs = require('fs');

packages/@angular/cli/utilities/check-package-manager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import * as chalk from 'chalk';
22
import {exec} from 'child_process';
33
import {CliConfig} from '../models/config';
4+
import denodeify = require('denodeify');
45

5-
const Promise = require('../ember-cli/lib/ext/promise');
6-
const execPromise = Promise.denodeify(exec);
6+
const execPromise = denodeify(exec);
77
const packageManager = CliConfig.fromGlobal().get('packageManager');
88

99

tests/e2e/tests/generate/module/module-routing-child-folder.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ import { expectFileToExist } from '../../../utils/fs';
55
import { expectToFail } from '../../../utils/utils';
66

77

8-
const Promise = require('@angular/cli/ember-cli/lib/ext/promise');
9-
108
export default function () {
119
const root = process.cwd();
1210
const testPath = join(root, 'src', 'app');

0 commit comments

Comments
 (0)