Skip to content

Commit 57ac7f3

Browse files
committed
fix(@angular-devkit/build-angular): remove left-over forkTypeChecker option
(cherry picked from commit 4c8e032)
1 parent 7c288c8 commit 57ac7f3

File tree

6 files changed

+3
-14
lines changed

6 files changed

+3
-14
lines changed

packages/angular_devkit/build_angular/src/browser/schema.json

-5
Original file line numberDiff line numberDiff line change
@@ -344,11 +344,6 @@
344344
"description": "Generates a 'stats.json' file which can be analyzed using tools such as 'webpack-bundle-analyzer'.",
345345
"default": false
346346
},
347-
"forkTypeChecker": {
348-
"type": "boolean",
349-
"description": "Run the TypeScript type checker in a forked process.",
350-
"default": true
351-
},
352347
"budgets": {
353348
"description": "Budget thresholds to ensure parts of your application stay within boundaries which you set.",
354349
"type": "array",

packages/angular_devkit/build_angular/src/browser/specs/rebuild_spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ describe('Browser Builder rebuilds', () => {
151151
`,
152152
);
153153

154-
const overrides = { watch: true, forkTypeChecker: false };
154+
const overrides = { watch: true };
155155
const logger = new logging.Logger('');
156156
let logs: string[] = [];
157157
logger.subscribe(e => logs.push(e.message));
@@ -344,7 +344,7 @@ describe('Browser Builder rebuilds', () => {
344344
// `selector must be a string` errors on VE are part of the emit result, but on Ivy they only
345345
// show up in getNgSemanticDiagnostics. Since getNgSemanticDiagnostics is only called on the
346346
// type checker, we must disable it to get a failing fourth build with Ivy.
347-
const overrides = { watch: true, aot: true, forkTypeChecker: false };
347+
const overrides = { watch: true, aot: true };
348348
const logger = new logging.Logger('');
349349
let logs: string[] = [];
350350
logger.subscribe(e => logs.push(e.message));

packages/angular_devkit/build_angular/src/server/schema.json

-5
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,6 @@
220220
"description": "Generates a 'stats.json' file which can be analyzed using tools such as 'webpack-bundle-analyzer'.",
221221
"default": false
222222
},
223-
"forkTypeChecker": {
224-
"type": "boolean",
225-
"description": "Run the TypeScript type checker in a forked process.",
226-
"default": true
227-
},
228223
"watch": {
229224
"type": "boolean",
230225
"description": "Run build when files change.",

packages/angular_devkit/build_angular/src/utils/build-options.ts

-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ export interface BuildOptions {
5757
serviceWorker?: boolean;
5858
webWorkerTsConfig?: string;
5959
statsJson: boolean;
60-
forkTypeChecker: boolean;
6160
hmr?: boolean;
6261
main: string;
6362
polyfills?: string;

packages/angular_devkit/build_angular/src/utils/normalize-builder-schema.ts

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export function normalizeBrowserSchema(
5050
sourceMap: normalizedSourceMapOptions,
5151
preserveSymlinks: options.preserveSymlinks === undefined ? process.execArgv.includes('--preserve-symlinks') : options.preserveSymlinks,
5252
statsJson: options.statsJson || false,
53-
forkTypeChecker: options.forkTypeChecker || false,
5453
budgets: options.budgets || [],
5554
scripts: options.scripts || [],
5655
styles: options.styles || [],

packages/schematics/angular/migrations/update-12/update-angular-config.ts

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export default function (): Rule {
4747
for (const [, options] of allTargetOptions(target)) {
4848
delete options.experimentalRollupPass;
4949
delete options.lazyModules;
50+
delete options.forkTypeChecker;
5051
}
5152
}
5253
});

0 commit comments

Comments
 (0)