build: add legaci-cli e2e bazel build

Author: jbedard

.circleci/config.yml

@@ -254,6 +254,12 @@ jobs:
       - custom_attach_workspace
       - run: yarn build
 
+  build-bazel-e2e:
+    executor: action-executor
+    steps:
+      - custom_attach_workspace
+      - run: yarn bazel build //tests/legacy-cli/...
+
   test:
     executor: test-executor
     resource_class: xlarge
@@ -379,6 +385,12 @@ workflows:
           requires:
             - build
 
+      # Compile the e2e tests with bazel to ensure the non-runtime typescript
+      # compilation completes succesfully.
+      - build-bazel-e2e:
+          requires:
+            - build
+
       # Windows jobs
       - e2e-cli-win:
           requires:

lib/BUILD.bazel

@@ -0,0 +1,12 @@
+load("//tools:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "lib",
+    srcs = ["packages.ts"],
+    visibility = ["//visibility:public"],
+    deps = [
+        "//packages/angular_devkit/core",
+        "@npm//@types/node",
+        "@npm//typescript",
+    ],
+)

package.json

@@ -212,6 +212,7 @@
     "typescript": "4.7.1-rc",
     "verdaccio": "5.10.2",
     "verdaccio-auth-memory": "^10.0.0",
+    "webdriver-manager": "^12.1.8",
     "webpack": "5.72.1",
     "webpack-dev-middleware": "5.3.3",
     "webpack-dev-server": "4.9.0",

tests/legacy-cli/BUILD.bazel

@@ -0,0 +1,25 @@
+load("//tools:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "runner",
+    testonly = True,
+    srcs = glob(["**/*.ts"]),
+    data = [
+        "verdaccio.yaml",
+        "verdaccio_auth.yaml",
+    ],
+    deps = [
+        "//packages/angular_devkit/core",
+        "//packages/angular_devkit/core/node",
+        "//tests/legacy-cli/e2e/assets",
+        "//tests/legacy-cli/e2e/utils",
+        "@npm//@types/glob",
+        "@npm//@types/yargs-parser",
+        "@npm//ansi-colors",
+        "@npm//yargs-parser",
+
+        # Loaded dynamically at runtime, not compiletime deps
+        "//tests/legacy-cli/e2e/setup",
+        "//tests/legacy-cli/e2e/tests",
+    ],
+)

tests/legacy-cli/e2e/assets/BUILD.bazel

@@ -0,0 +1,11 @@
+load("//tools:defaults.bzl", "js_library")
+
+js_library(
+    name = "assets",
+    srcs = glob(["**"]),
+    visibility = ["//visibility:public"],
+    deps = [
+        "@npm//jasmine-spec-reporter",
+        "@npm//ts-node",
+    ],
+)

tests/legacy-cli/e2e/ng-snapshot/BUILD.bazel

@@ -0,0 +1,8 @@
+load("//tools:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "ng-snapshot",
+    srcs = [],
+    data = ["package.json"],
+    visibility = ["//visibility:public"],
+)

tests/legacy-cli/e2e/setup/BUILD.bazel

@@ -0,0 +1,11 @@
+load("//tools:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "setup",
+    testonly = True,
+    srcs = glob(["**/*.ts"]),
+    visibility = ["//visibility:public"],
+    deps = [
+        "//tests/legacy-cli/e2e/utils",
+    ],
+)

tests/legacy-cli/e2e/tests/BUILD.bazel

@@ -0,0 +1,20 @@
+load("//tools:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "tests",
+    testonly = True,
+    srcs = glob(["**/*.ts"]),
+    visibility = ["//visibility:public"],
+    deps = [
+        "//tests/legacy-cli/e2e/ng-snapshot",
+        "//tests/legacy-cli/e2e/utils",
+        "@npm//@types/express",
+        "@npm//@types/glob",
+        "@npm//@types/node-fetch",
+        "@npm//@types/semver",
+        "@npm//express",
+        "@npm//glob",
+        "@npm//node-fetch",
+        "@npm//semver",
+    ],
+)

tests/legacy-cli/e2e/utils/BUILD.bazel

@@ -0,0 +1,26 @@
+load("//tools:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "utils",
+    testonly = True,
+    srcs = glob(["**/*.ts"]),
+    visibility = ["//visibility:public"],
+    deps = [
+        "//lib",
+        "//tests/legacy-cli/e2e/ng-snapshot",
+        "@npm//@types/glob",
+        "@npm//@types/node-fetch",
+        "@npm//@types/semver",
+        "@npm//@types/yargs-parser",
+        "@npm//ansi-colors",
+        "@npm//glob",
+        "@npm//protractor",
+        "@npm//puppeteer",
+        "@npm//rxjs",
+        "@npm//semver",
+        "@npm//tree-kill",
+        "@npm//verdaccio",
+        "@npm//verdaccio-auth-memory",
+        "@npm//webdriver-manager",
+    ],
+)

tests/legacy-cli/e2e/utils/process.ts

@@ -147,7 +147,7 @@ function _exec(options: ExecOptions, cmd: string, args: string[]): Promise<Proce
 export function extractNpmEnv() {
   return Object.keys(process.env)
     .filter((v) => NPM_CONFIG_RE.test(v))
-    .reduce(
+    .reduce<NodeJS.ProcessEnv>(
       (vars, n) => {
         vars[n] = process.env[n];
         return vars;

tools/defaults.bzl

@@ -1,7 +1,7 @@
 """Re-export of some bazel rules with repository-wide defaults."""
 
 load("@npm//@bazel/concatjs/internal:build_defs.bzl", _ts_library = "ts_library_macro")
-load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin", _pkg_npm = "pkg_npm")
+load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin", _js_library = "js_library", _pkg_npm = "pkg_npm")
 load("@rules_pkg//:pkg.bzl", "pkg_tar")
 load("@npm//@angular/dev-infra-private/bazel:extract_js_module_output.bzl", "extract_js_module_output")
 load("@aspect_bazel_lib//lib:utils.bzl", "to_label")
@@ -50,6 +50,8 @@ def ts_library(
         **kwargs
     )
 
+js_library = _js_library
+
 def pkg_npm(name, pkg_deps = [], use_prodmode_output = False, **kwargs):
     """Override of pkg_npm to produce package outputs and version substitutions conventional to the angular-cli project.
 

yarn.lock

@@ -10853,7 +10853,7 @@ [email protected]:
     "@types/selenium-webdriver" "^3.0.0"
     selenium-webdriver "^3.0.1"
 
-webdriver-manager@^12.1.7:
+webdriver-manager@^12.1.7, webdriver-manager@^12.1.8:
   version "12.1.8"
   resolved "https://registry.yarnpkg.com/webdriver-manager/-/webdriver-manager-12.1.8.tgz#5e70e73eaaf53a0767d5745270addafbc5905fd4"
   integrity sha512-qJR36SXG2VwKugPcdwhaqcLQOD7r8P2Xiv9sfNbfZrKBnX243iAkOueX1yAmeNgIKhJ3YAT/F2gq6IiEZzahsg==