Skip to content

Commit 4dd6d33

Browse files
alan-agius4Keen Yee Liau
authored and
Keen Yee Liau
committed
fix(@angular-devkit/build-angular): update speed-measure-webpack-plugin to 1.3.1
This fixes the issue of it generating an empty `speed-measure-plugin.json`. Fixes #12763
1 parent ba6b66d commit 4dd6d33

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

packages/angular_devkit/build_angular/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"semver": "5.6.0",
3838
"source-map-support": "0.5.10",
3939
"source-map-loader": "0.2.4",
40-
"speed-measure-webpack-plugin": "1.3.0",
40+
"speed-measure-webpack-plugin": "1.3.1",
4141
"stats-webpack-plugin": "0.7.0",
4242
"style-loader": "0.23.1",
4343
"stylus": "0.54.5",

packages/angular_devkit/build_angular/test/browser/profile_spec_large.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
import { runTargetSpec } from '@angular-devkit/architect/testing';
10-
import { normalize } from '@angular-devkit/core';
10+
import { normalize, virtualFs } from '@angular-devkit/core';
1111
import { tap } from 'rxjs/operators';
1212
import { browserTargetSpec, host } from '../utils';
1313

@@ -21,8 +21,11 @@ describe('Browser Builder profile', () => {
2121
runTargetSpec(host, browserTargetSpec, overrides).pipe(
2222
tap((buildEvent) => expect(buildEvent.success).toBe(true)),
2323
tap(() => {
24+
const speedMeasureLogPath = normalize('speed-measure-plugin.json');
2425
expect(host.scopedSync().exists(normalize('chrome-profiler-events.json'))).toBe(true);
25-
expect(host.scopedSync().exists(normalize('speed-measure-plugin.json'))).toBe(true);
26+
expect(host.scopedSync().exists(speedMeasureLogPath)).toBe(true);
27+
const content = virtualFs.fileBufferToString(host.scopedSync().read(speedMeasureLogPath));
28+
expect(content).toContain('plugins');
2629
}),
2730
).toPromise().then(done, done.fail);
2831
});

yarn.lock

+4-9
Original file line numberDiff line numberDiff line change
@@ -9328,10 +9328,10 @@ spdy@^4.0.0:
93289328
select-hose "^2.0.0"
93299329
spdy-transport "^3.0.0"
93309330

9331-
9332-
version "1.3.0"
9333-
resolved "https://registry.yarnpkg.com/speed-measure-webpack-plugin/-/speed-measure-webpack-plugin-1.3.0.tgz#c7ffafef513df3d63d5d546c8fc1986dfc4969aa"
9334-
integrity sha512-b9Yd0TrzceMVYSbuamM1sFsGM1oVfyFTM22gOoyLhymNvBVApuYpkdFOgYkKJpN/KhTpcCYcTGHg7X+FJ33Vvw==
9331+
9332+
version "1.3.1"
9333+
resolved "https://registry.yarnpkg.com/speed-measure-webpack-plugin/-/speed-measure-webpack-plugin-1.3.1.tgz#69840a5cdc08b4638697dac7db037f595d7f36a0"
9334+
integrity sha512-qVIkJvbtS9j/UeZumbdfz0vg+QfG/zxonAjzefZrqzkr7xOncLVXkeGbTpzd1gjCBM4PmVNkWlkeTVhgskAGSQ==
93359335
dependencies:
93369336
chalk "^2.0.1"
93379337

@@ -10081,11 +10081,6 @@ typedarray@^0.0.6:
1008110081
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
1008210082
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
1008310083

10084-
10085-
version "3.2.2"
10086-
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.2.2.tgz#fe8101c46aa123f8353523ebdcf5730c2ae493e5"
10087-
integrity sha512-VCj5UiSyHBjwfYacmDuc/NOk4QQixbE+Wn7MFJuS0nRuPQbof132Pw4u53dm264O8LPc2MVsc7RJNml5szurkg==
10088-
1008910084
1009010085
version "3.2.4"
1009110086
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.2.4.tgz#c585cb952912263d915b462726ce244ba510ef3d"

0 commit comments

Comments
 (0)