Skip to content

Commit 4a5973c

Browse files
filipesilvaKeen Yee Liau
authored and
Keen Yee Liau
committed
build: workaround yarn tgz bug
1 parent f5fe1b6 commit 4a5973c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

benchmark/aio/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@
77
"initialize": "yarn clone && yarn setup && yarn update",
88
"clone": "(git clone https://github.com/angular/angular --depth 1 || true) && cd angular && git fetch origin dd2a650c3455f3bc0a88f8181758a84aacb25fea && git checkout -f FETCH_HEAD",
99
"setup": "cd angular && yarn && cd aio && yarn && yarn setup",
10+
"update": "cd angular/aio && yarn add ../../../../dist/_angular-devkit_build-angular.tgz --dev",
1011
"//": "Shouldn't need to install the package twice, but the first install seems to leave two @ngtools/webpack installs around.",
11-
"update": "cd angular/aio && yarn add ../../../../dist/@angular-devkit_build-angular.tgz --dev && yarn add ../../../../dist/_angular-devkit_build-angular.tgz --dev",
12+
"postupdate": "cd angular/aio && yarn add ../../../../dist/_angular-devkit_build-angular.tgz --dev",
1213
"benchmark": "cd angular/aio && benchmark --verbose -- yarn ~~build --configuration=stable"
1314
},
1415
"keywords": [],

lib/packages.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,9 @@ export const packages: PackageMap =
212212
relative: path.relative(path.dirname(__dirname), pkgRoot),
213213
main: path.resolve(pkgRoot, 'src/index.ts'),
214214
private: packageJson.private,
215-
tar: path.join(distRoot, name.replace('/', '_') + '.tgz'),
215+
// yarn doesn't take kindly to @ in tgz filenames
216+
// https://github.com/yarnpkg/yarn/issues/6339
217+
tar: path.join(distRoot, name.replace(/\/|@/g, '_') + '.tgz'),
216218
bin,
217219
name,
218220
packageJson,

0 commit comments

Comments
 (0)